linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8qxp: fix mbox-cells
@ 2019-03-13  9:24 Peng Fan
  2019-03-15 10:23 ` Aisheng Dong
  2019-03-21 11:36 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2019-03-13  9:24 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	dl-linux-imx, Aisheng Dong, Anson Huang, Daniel Baluta,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: van.freenix, Peng Fan

Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but
actually mu0-4 could be used to communicate with SCU. So fix the
mbox-cells.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 4c3dd95ed488..16766838ac77 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -328,7 +328,7 @@
 			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
 			reg = <0x5d1b0000 0x10000>;
 			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
-			#mbox-cells = <0>;
+			#mbox-cells = <2>;
 			status = "disabled";
 		};
 
@@ -343,7 +343,7 @@
 			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
 			reg = <0x5d1e0000 0x10000>;
 			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
-			#mbox-cells = <0>;
+			#mbox-cells = <2>;
 			status = "disabled";
 		};
 
@@ -351,7 +351,7 @@
 			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
 			reg = <0x5d1f0000 0x10000>;
 			interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
-			#mbox-cells = <0>;
+			#mbox-cells = <2>;
 			status = "disabled";
 		};
 
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
  2019-03-13  9:24 [PATCH] arm64: dts: imx8qxp: fix mbox-cells Peng Fan
@ 2019-03-15 10:23 ` Aisheng Dong
  2019-03-21  4:44   ` Peng Fan
  2019-03-21 11:36 ` Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Aisheng Dong @ 2019-03-15 10:23 UTC (permalink / raw)
  To: Peng Fan, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, dl-linux-imx, Anson Huang, Daniel Baluta, devicetree,
	linux-arm-kernel, linux-kernel
  Cc: van.freenix

> From: Peng Fan
>
> Subject: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
> 
> Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but actually
> mu0-4 could be used to communicate with SCU. So fix the mbox-cells.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Dong Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 4c3dd95ed488..16766838ac77 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -328,7 +328,7 @@
>  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
>  			reg = <0x5d1b0000 0x10000>;
>  			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> -			#mbox-cells = <0>;
> +			#mbox-cells = <2>;
>  			status = "disabled";
>  		};
> 
> @@ -343,7 +343,7 @@
>  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
>  			reg = <0x5d1e0000 0x10000>;
>  			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> -			#mbox-cells = <0>;
> +			#mbox-cells = <2>;
>  			status = "disabled";
>  		};
> 
> @@ -351,7 +351,7 @@
>  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
>  			reg = <0x5d1f0000 0x10000>;
>  			interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> -			#mbox-cells = <0>;
> +			#mbox-cells = <2>;
>  			status = "disabled";
>  		};
> 
> --
> 2.16.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
  2019-03-15 10:23 ` Aisheng Dong
@ 2019-03-21  4:44   ` Peng Fan
  0 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2019-03-21  4:44 UTC (permalink / raw)
  To: Aisheng Dong, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, dl-linux-imx, Anson Huang, Daniel Baluta, devicetree,
	linux-arm-kernel, linux-kernel
  Cc: van.freenix

Hi Shawn,

> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019年3月15日 18:24
> To: Peng Fan <peng.fan@nxp.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; Anson Huang <anson.huang@nxp.com>; Daniel Baluta
> <daniel.baluta@nxp.com>; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Cc: van.freenix@gmail.com
> Subject: RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
> 
> > From: Peng Fan
> >
> > Subject: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
> >
> > Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but actually
> > mu0-4 could be used to communicate with SCU. So fix the mbox-cells.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> 
> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Would you pick up this patch?

Thanks,
Peng.

> 
> Regards
> Dong Aisheng
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 4c3dd95ed488..16766838ac77 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -328,7 +328,7 @@
> >  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> >  			reg = <0x5d1b0000 0x10000>;
> >  			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> > -			#mbox-cells = <0>;
> > +			#mbox-cells = <2>;
> >  			status = "disabled";
> >  		};
> >
> > @@ -343,7 +343,7 @@
> >  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> >  			reg = <0x5d1e0000 0x10000>;
> >  			interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> > -			#mbox-cells = <0>;
> > +			#mbox-cells = <2>;
> >  			status = "disabled";
> >  		};
> >
> > @@ -351,7 +351,7 @@
> >  			compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> >  			reg = <0x5d1f0000 0x10000>;
> >  			interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> > -			#mbox-cells = <0>;
> > +			#mbox-cells = <2>;
> >  			status = "disabled";
> >  		};
> >
> > --
> > 2.16.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
  2019-03-13  9:24 [PATCH] arm64: dts: imx8qxp: fix mbox-cells Peng Fan
  2019-03-15 10:23 ` Aisheng Dong
@ 2019-03-21 11:36 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-03-21 11:36 UTC (permalink / raw)
  To: Peng Fan
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
	Aisheng Dong, Anson Huang, Daniel Baluta, devicetree,
	linux-arm-kernel, linux-kernel, van.freenix

On Wed, Mar 13, 2019 at 09:24:19AM +0000, Peng Fan wrote:
> Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but
> actually mu0-4 could be used to communicate with SCU. So fix the
> mbox-cells.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-21 11:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13  9:24 [PATCH] arm64: dts: imx8qxp: fix mbox-cells Peng Fan
2019-03-15 10:23 ` Aisheng Dong
2019-03-21  4:44   ` Peng Fan
2019-03-21 11:36 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).