From: Aisheng Dong <aisheng.dong@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"edubezval@gmail.com" <edubezval@gmail.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Peng Fan <peng.fan@nxp.com>, "heiko@sntech.de" <heiko@sntech.de>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"agross@kernel.org" <agross@kernel.org>,
"olof@lixom.net" <olof@lixom.net>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V12 3/5] thermal: imx_sc: add i.MX system controller thermal support
Date: Thu, 16 May 2019 10:39:34 +0000 [thread overview]
Message-ID: <AM0PR04MB4211EF0D257E502C3BF917D0800A0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB3PR0402MB39163877C25E5BE7E10C96B7F5250@DB3PR0402MB3916.eurprd04.prod.outlook.com>
[...]
> > > + if (!sensor)
> > > + return -ENOMEM;
> > > +
> > > + ret = thermal_zone_of_get_sensor_id(child,
> > > + &sensor_specs,
> >
> > It looks a bit strange why need sensor_specs as you even did not use it.
>
> It is because parsing the phandle arguments needs it, such as the
> thermal_zone_of_sensor_register() function needs this pointer to be passed
> back to check the elements are valid or NOT, so the API does NOT define it as
> local structure. The API NOT just return the sensor id, but also the
> of_phandle_args address, although we do NOT need it at all here.
The main problem is this one introduced in 2/5 which needs get ack from maintainer.
For me, I would suggest to make sensor_specs transparent to user if
it's really not needed by users.
Please try to make it either optional or hide to core users as well.
And I guess the later one is doable after a glance at the core code.
Regards
Dong Aisheng
next prev parent reply other threads:[~2019-05-16 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 3:22 [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding Anson Huang
2019-04-16 3:22 ` [PATCH V12 2/5] thermal: of-thermal: add API for getting sensor ID from DT Anson Huang
2019-05-16 9:38 ` Daniel Lezcano
2019-05-17 6:37 ` Anson Huang
2019-04-16 3:22 ` [PATCH V12 3/5] thermal: imx_sc: add i.MX system controller thermal support Anson Huang
2019-04-17 7:45 ` Aisheng Dong
2019-04-17 13:42 ` Anson Huang
2019-05-16 10:39 ` Aisheng Dong [this message]
2019-05-16 10:46 ` Anson Huang
2019-05-09 1:44 ` Anson Huang
2019-05-16 2:53 ` Anson Huang
2019-05-16 9:38 ` Daniel Lezcano
2019-04-16 3:22 ` [PATCH V12 4/5] defconfig: arm64: " Anson Huang
2019-04-16 3:22 ` [PATCH V12 5/5] arm64: dts: imx: add i.MX8QXP " Anson Huang
2019-04-16 16:18 ` Daniel Lezcano
2019-04-24 21:21 ` Rob Herring
2019-04-17 3:31 ` [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding Aisheng Dong
2019-04-17 12:46 ` Anson Huang
2019-04-24 20:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4211EF0D257E502C3BF917D0800A0@AM0PR04MB4211.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=agross@kernel.org \
--cc=anson.huang@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).