From: Leonard Crestez <leonard.crestez@nxp.com>
To: David Howells <dhowells@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: kernel test robot <rong.a.chen@intel.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@01.org" <lkp@01.org>
Subject: Re: [LKP] [sunrpc] 6a7da2a288: kernel_BUG_at_lib/iov_iter.c
Date: Sat, 3 Nov 2018 15:49:43 +0000 [thread overview]
Message-ID: <AM0PR04MB42907C7E4A7E1B09ED7B6BBEEEC80@AM0PR04MB4290.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 7958.1541119812@warthog.procyon.org.uk
On 11/2/2018 2:50 AM, David Howells wrote:
> kernel test robot <rong.a.chen@intel.com> wrote:
>
>> FYI, we noticed the following commit (built with gcc-7):
>>
>> commit: 6a7da2a288ce412d7ac117a2912a7b0d9104ee6d ("[RFC] sunrpc: Fix flood of warnings from iov_iter_kvec in linux-next")
>> url: https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FLeonard-Crestez%2Fsunrpc-Fix-flood-of-warnings-from-iov_iter_kvec-in-linux-next%2F20181101-070713&data=02%7C01%7Cleonard.crestez%40nxp.com%7C0b22a6d58a5242277ca008d6405d28b3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636767166190134069&sdata=335WGS8H6GRfqp%2BDmocDQ8mowhe7a0RxKbfM6rSgJ3g%3D&reserved=0
>> base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
>>
>> in testcase: boot
>>
>> on test machine: qemu-system-x86_64 -enable-kvm -cpu kvm64,+ssse3 -smp 2 -m 8G
>>
>> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
> Ummm... You can't just apply that commit to Trond's linux-next branch unless
> that branch also includes the iov_iter changes from my afs-next branch.
>
> Before those changes, ITER_KVEC is required:
>
> BUG_ON(!(direction & ITER_KVEC));
>
> and after, it will be prohibited:
>
> WARN_ON(direction & ~(READ | WRITE));
>
> The reason for this is that have yet more patches that split the direction
> from the iov_iter::type member into their own member and turn the types into a
> simple integer sequence instead of a bit mask.
It's not clear how such conflicts should be handled. Maybe patches from
one tree should be pulled into the other earlier so that merging "just
works"?
--
Regards,
Leonard
prev parent reply other threads:[~2018-11-03 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 12:49 [RFC] sunrpc: Fix flood of warnings from iov_iter_kvec in linux-next Leonard Crestez
2018-10-31 14:31 ` David Howells
2018-10-31 23:32 ` Stephen Rothwell
2018-11-02 0:16 ` [LKP] [sunrpc] 6a7da2a288: kernel_BUG_at_lib/iov_iter.c kernel test robot
2018-11-02 0:50 ` David Howells
2018-11-03 15:49 ` Leonard Crestez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB42907C7E4A7E1B09ED7B6BBEEEC80@AM0PR04MB4290.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkp@01.org \
--cc=rong.a.chen@intel.com \
--cc=sfr@canb.auug.org.au \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).