From: Peng Fan <peng.fan@nxp.com>
To: "Peng Fan" <peng.fan@nxp.com>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"mripard@kernel.org" <mripard@kernel.org>,
"wens@csie.org" <wens@csie.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api
Date: Thu, 16 Jan 2020 08:28:23 +0000 [thread overview]
Message-ID: <AM0PR04MB448174E1DE647E9F2F65106988360@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1576672860-14420-1-git-send-email-peng.fan@nxp.com>
Hi Linus,
> Subject: [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api
Would you pick this patch up?
Per Uwe, this v1 patch use %pe is better that v2 use %d.
Thanks,
Peng.
>
> From: Peng Fan <peng.fan@nxp.com>
>
> platform_irq_count() and platform_get_irq() is the more generic way
> (independent of device trees) to determine the count of available interrupts.
> So use this instead.
>
> As platform_irq_count() might return an error code (which of_irq_count
> doesn't) some additional handling is necessary.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index aa9dcde0f069..cc66a6429a06 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -15,7 +15,6 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_device.h>
> -#include <linux/of_irq.h>
> #include <linux/pinctrl/pinconf-generic.h> #include
> <linux/pinctrl/pinconf.h> #include <linux/pinctrl/pinctrl.h> @@ -739,7
> +738,14 @@ static int armada_37xx_irqchip_register(struct platform_device
> *pdev,
> return ret;
> }
>
> - nr_irq_parent = of_irq_count(np);
> + nr_irq_parent = platform_irq_count(pdev);
> + if (nr_irq_parent < 0) {
> + if (nr_irq_parent != -EPROBE_DEFER)
> + dev_err(dev, "Couldn't determine irq count: %pe\n",
> + ERR_PTR(nr_irq_parent));
> + return nr_irq_parent;
> + }
> +
> spin_lock_init(&info->irq_lock);
>
> if (!nr_irq_parent) {
> @@ -776,7 +782,7 @@ static int armada_37xx_irqchip_register(struct
> platform_device *pdev,
> if (!girq->parents)
> return -ENOMEM;
> for (i = 0; i < nr_irq_parent; i++) {
> - int irq = irq_of_parse_and_map(np, i);
> + int irq = platform_get_irq(pdev, i);
>
> if (irq < 0)
> continue;
> --
> 2.16.4
next prev parent reply other threads:[~2020-01-16 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 12:43 [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api Peng Fan
2019-12-18 12:43 ` [PATCH 2/2] pinctrl: sunxi: sun50i-h5 use platform_irq_count Peng Fan
2020-01-07 8:56 ` Linus Walleij
2019-12-18 12:48 ` [PATCH 1/2] pinctrl: mvebu: armada-37xx: use use platform api Fabio Estevam
2019-12-18 12:53 ` Peng Fan
2019-12-18 12:57 ` Fabio Estevam
2019-12-18 14:59 ` Andrew Lunn
2019-12-18 15:09 ` Fabio Estevam
2019-12-18 15:28 ` Fabio Estevam
2020-01-08 7:52 ` Uwe Kleine-König
2020-01-16 8:28 ` Peng Fan [this message]
2020-01-23 15:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB448174E1DE647E9F2F65106988360@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).