From: Han Xu <han.xu@nxp.com>
To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>,
"cyrille.pitchen@wedev4u.fr" <cyrille.pitchen@wedev4u.fr>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>
Cc: "boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"kdasu.kdev@gmail.com" <kdasu.kdev@gmail.com>,
"richard@nod.at" <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>
Subject: RE: [EXT] Re: [PATCH] mtd: spi-nor: Add prep/unprep for spi_nor_resume
Date: Thu, 6 Jun 2019 22:33:29 +0000 [thread overview]
Message-ID: <AM0PR04MB4961A2E7620DF5BD346C94D097170@AM0PR04MB4961.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ae82d8ea-dd85-0bc3-ff2d-0ba57f635030@microchip.com>
> -----Original Message-----
> From: Tudor.Ambarus@microchip.com <Tudor.Ambarus@microchip.com>
> Sent: Thursday, June 6, 2019 12:46 AM
> To: Han Xu <han.xu@nxp.com>; cyrille.pitchen@wedev4u.fr;
> marek.vasut@gmail.com
> Cc: boris.brezillon@free-electrons.com; f.fainelli@gmail.com;
> kdasu.kdev@gmail.com; richard@nod.at; linux-kernel@vger.kernel.org;
> linux-mtd@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> computersforpeace@gmail.com
> Subject: [EXT] Re: [PATCH] mtd: spi-nor: Add prep/unprep for
> spi_nor_resume
>
> Caution: EXT Email
>
> Hi, Han,
>
> On 04/25/2019 12:08 AM, Han Xu wrote:
> > External E-Mail
> >
> >
> > In the new implemented spi_nor_resume function, the spi_nor_init()
> > should be braced by prep/unprep functions._
> >
>
> Would you please explain why this is needed? Have you tried a
> suspend/resume cycle while a write was in progress and it failed?
Same as all other functions that hooked up with mtd ops, such as
_read/_write/_lock/_unlock, the _resume function also need to call the
lower level controller's prep/unprep functions to properly handle runtime
pm and mutex.
I didn't try suspend/resume during writing, but found accessing registers
without enabling clock when system resumed.
>
> Thanks,
> ta
prev parent reply other threads:[~2019-06-06 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 21:08 [PATCH] mtd: spi-nor: Add prep/unprep for spi_nor_resume Han Xu
2019-06-06 5:45 ` Tudor.Ambarus
2019-06-06 22:33 ` Han Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4961A2E7620DF5BD346C94D097170@AM0PR04MB4961.eurprd04.prod.outlook.com \
--to=han.xu@nxp.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).