linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	Roy Zang <roy.zang@nxp.com>, "M.h. Lian" <minghuan.lian@nxp.com>
Subject: RE: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor
Date: Fri, 26 Oct 2018 02:20:21 +0000	[thread overview]
Message-ID: <AM3PR04MB121709BD837D4E5EA3E28B1A84F00@AM3PR04MB1217.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181025134522.GE214775@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

Thanks a lot for your comments!

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: 2018年10月25日 21:45
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> bhelgaas@google.com; lorenzo.pieralisi@arm.com; Roy Zang
> <roy.zang@nxp.com>; M.h. Lian <minghuan.lian@nxp.com>
> Subject: Re: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound
> window disable accessor
> 
>   $ git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c |
> head
>   6e0832fa432e PCI: Collect all native drivers under drivers/pci/controller/
>   3f43ccc4ea1b PCI: dwc: Remove old MSI IRQs API
>   8cfab3cf63cf PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate
>   84d897d69938 PCI: layerscape: Change default error response behavior
>   a335b122ba27 PCI: layerscape: Add support for ls1012a
>   03fc6134c260 PCI: layerscape: Add support for ls1088a
>   8f89357094e6 PCI: layerscape: Add support for ls2088a
>   c3f909398827 PCI: layerscape: Remove unnecessary class code fixup
>   e44abfed6fcb PCI: dwc: Add accessors for write permission of DBI
> read-only registers
>   4a2745d760fa PCI: layerscape: Disable outbound windows configured by
> bootloader
> 
> Make yours match, e.g., "PCI: layerscape: Call dw_pcie_disable_atu()
> correctly"
> 

Yes, will uniform the subject in v2.

> On Thu, Oct 25, 2018 at 08:53:37AM +0000, Z.q. Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > This issue is introduced by commit 4a2745d760fac ("PCI: layerscape:
> > Disable outbound windows configured by bootloader").
> 
> Conventional commit reference:
> 
>   $ git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h
> (\"%s\")%n" 4a2745d760fac
>   4a2745d760fa ("PCI: layerscape: Disable outbound windows configured by
> bootloader")
> 

Will correct the commit ID length.

> Holy cow, this has been broken since v4.14.  If fixing this makes a difference,
> you might want to tag it for stable.
> 

How can I tag it for stable?

> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 69f3f1a5a782..b2085988dbee 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct
> ls_pcie *pcie)
> >  	int i;
> >
> >  	for (i = 0; i < PCIE_IATU_NUM; i++)
> > -		dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
> > +		dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
> >  }
> >
> >  static int ls1021_pcie_link_up(struct dw_pcie *pci)
> > --
> > 2.17.1
> >

Thanks,
Zhiqiang

  reply	other threads:[~2018-10-26  2:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  8:53 Z.q. Hou
2018-10-25 13:45 ` Bjorn Helgaas
2018-10-26  2:20   ` Z.q. Hou [this message]
2018-10-29 16:31     ` Bjorn Helgaas
2018-11-07  4:41       ` Z.q. Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM3PR04MB121709BD837D4E5EA3E28B1A84F00@AM3PR04MB1217.eurprd04.prod.outlook.com \
    --to=zhiqiang.hou@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=minghuan.lian@nxp.com \
    --cc=roy.zang@nxp.com \
    --subject='RE: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).