From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753015AbcHZKn4 (ORCPT ); Fri, 26 Aug 2016 06:43:56 -0400 Received: from mail-db5eur01on0067.outbound.protection.outlook.com ([104.47.2.67]:51336 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751135AbcHZKny (ORCPT ); Fri, 26 Aug 2016 06:43:54 -0400 From: Yongcai Huang To: Arnd Bergmann CC: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , Fabio Estevam , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" Subject: RE: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D Thread-Topic: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D Thread-Index: AQHR/0m8REtIaHPNrU+vEjd14XL3VaBa8aWAgAAXmqA= Date: Fri, 26 Aug 2016 10:28:15 +0000 Message-ID: References: <1472209971-32469-1-git-send-email-Anson.Huang@nxp.com> <1472209971-32469-4-git-send-email-Anson.Huang@nxp.com> <3283479.PKRDjkX0Md@wuerfel> In-Reply-To: <3283479.PKRDjkX0Md@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-originating-ip: [199.59.231.64] x-ms-office365-filtering-correlation-id: c363d3b1-3fa5-4178-dc11-08d3cd9bb074 x-microsoft-exchange-diagnostics: 1;VI1PR0402MB2751;6:5YCE7myOuh4cPb4EP9OyuwS4aclX1Gj+62EK8YKYz9ZUVtwuqNIB6I5vDf+p7ubNbkA3TbnDiKOhjVRHM0ODxNfgRX4c8Ya4vWId2cCTOGAYrM2smehmr+LBXpA/4zEGd9QCBPiWsBxNFRl2uy7S+TJ7Tzo6ld69fCYq11DLjDCFcTvO9QU9eGBAbpfGra3pTPnjYP9IxGCFFqAz4+QcXZ+zXp1RCk1EiLMhY38BxvUst/64I4K3cNb1baBr+7piEORCLQj1TRn6rjyAw4MWEQPh+ig+PHnm9IX0VMyg6toGb2qSV4BzDRcAfVIswOJEvOap5vc2UNaZItw3mAUE6g==;5:VpeMvb1U5LEENSjjbEsT6Ui2Pkv3AyME58nCTrX4Vo5e0zW1Alu/GRYECvEB7KggKbEN1eq/C0UwsQnxovp5Q6NUbbZG7LwHR6YgDwjuX5JgLbG51Q9zSmlDKaAuU4RDJjNDiUN5+2cN0TayW7K+4w==;24:2gROX5nZEYXUb9bElcQ+/mnMQjTaVAXjQvo96/pKHOYpELUo3L2lh2qPHSe60fB4LkxVCMo+zKt/U8TUIJrKz1jWWDGhneeh0Nl/y/7TnHo=;7:vhmrFkr1Jx3V2kX7Df5pFyLmvPNlda29YDpOhCsnSTcZ3YS9+FO/7eMMohgIuZbBCRv5doM2mQqTRkX4CSFuUGNJJwbxjUYj4DPrpegitwhi+kijMG5dSV55GSfOG7SN4tUUHzcoNNICrZ0BWwScDS0ka1zWLEVHmh4bdcSOzeCb9GCCnPp35Y9d3Z0UDrLE2A11TANRNABy9QhS8EjZsxH+BXI7Fb/8WHWYEPbmSq1SCm5i87XYZsZholzlW7uS x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0402MB2751; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:VI1PR0402MB2751;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0402MB2751; x-forefront-prvs: 00462943DE x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(199003)(377424004)(24454002)(13464003)(189002)(7736002)(2906002)(19580405001)(76576001)(7846002)(97736004)(3280700002)(87936001)(92566002)(2900100001)(3660700001)(11100500001)(4326007)(86362001)(9686002)(76176999)(2950100001)(66066001)(7696003)(54356999)(19580395003)(5002640100001)(74316002)(106116001)(8676002)(81166006)(105586002)(81156014)(33656002)(8936002)(101416001)(305945005)(110136002)(3846002)(586003)(5660300001)(189998001)(68736007)(6116002)(5250100002)(102836003)(106356001)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB2751;H:AM3PR04MB1315.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2016 10:28:15.1533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2751 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7QAi0Qm010230 Best Regards! Anson Huang > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: 2016-08-26 4:59 PM > To: Yongcai Huang > Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; shawnguo@kernel.org; kernel@pengutronix.de; > Fabio Estevam ; robh+dt@kernel.org; > mark.rutland@arm.com; linux@armlinux.org.uk > Subject: Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D > > On Friday, August 26, 2016 7:12:51 PM CEST Anson Huang wrote: > > i.MX7D has 2 cortex-a7 ARM core, add support for booting up SMP kernel > > with 2 CPUs. > > > > The existing i.MX SMP code is designed for i.MX6 series SoCs which > > have cortex-a9 ARM core, but i.MX7D has 2 cortex-a7 ARM core, so we > > need to add runtime check for those differences between cortex-a9 and > > cortex-a7. > > > > Signed-off-by: Anson Huang > > > > Can't you just point i.MX7D to start from secondary_startup rather than > v7_secondary_startup? > > ENTRY(v7_secondary_startup) > + .word 0xc070 @ 0xc07 is cortex-a7 id > + .word 0xfff0 @ mask for core type > + > > This looks like you are trying to execute instructions that are actually data. Does > this work? > > On a side note, could you rename v7_secondary_startup to > imx6_secondary_startup? The name sounds overly generic on a multiplatform > kernel. > > Arnd Thanks for review, yes, I made a mistake here, the data should put in another place, but it accidently can work and boot up secondary CPU (see below the objdump), and also, I can just use secondary_startup for i.MX7D. So I will leave this file untouched, will verify the function next Mon and send out a V2 patch. 10 00000004 : 11 4: 0000c070 andeq ip, r0, r0, ror r0 12 8: 0000fff0 strdeq pc, [r0], -r0 Anson.