From: Leo Li <leoyang.li@nxp.com>
To: Scott Wood <oss@buserror.net>, Karim Eshapa <karim.eshapa@gmail.com>
Cc: Roy Pledge <roy.pledge@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies.
Date: Tue, 27 Jun 2017 16:38:00 +0000 [thread overview]
Message-ID: <AM4PR0401MB1699F4CD65C50361933D2FA48FDC0@AM4PR0401MB1699.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20170625024638.t6awgp7omzq5dcnk@home.buserror.net>
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Saturday, June 24, 2017 9:47 PM
> To: Karim Eshapa <karim.eshapa@gmail.com>
> Cc: Roy Pledge <roy.pledge@nxp.com>; linux-kernel@vger.kernel.org;
> Claudiu Manoil <claudiu.manoil@nxp.com>; colin.king@canonical.com;
> linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; Leo Li
> <leoyang.li@nxp.com>
> Subject: Re: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck
> hacking jiffies.
>
> On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote:
> > Use msleep() instead of stucking with
> > long delay will be more efficient.
> >
> > Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
> > ---
> > drivers/soc/fsl/qbman/qman.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Acked-by: Scott Wood <oss@buserror.net>
>
> (though the subject line should be "soc/qman: ...")
>
> Leo, are you going to send this patch (and other qman patches) via arm-soc?
Yes. I can take it through the pull request for soc/fsl via arm-soc. As mentioned in the feedback from David in another email, probably we should update the comment and commit message to mention how 10000 cycles becomes 1ms.
Regards,
Leo
next prev parent reply other threads:[~2017-06-27 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 19:46 [PATCH] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies Karim Eshapa
2017-04-29 20:43 ` [PATCH] drivers:soc:fsl:qbman:qman.c: unsigned long jiffies value Karim Eshapa
2017-04-29 23:32 ` Scott Wood
2017-04-30 1:09 ` Karim Eshapa
2017-05-04 4:58 ` [PATCH v2] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies Karim Eshapa
2017-05-04 21:07 ` Scott Wood
2017-05-04 23:30 ` Roy Pledge
2017-05-05 5:45 ` [PATCH v3] " Karim Eshapa
2017-06-25 2:46 ` [v3] " Scott Wood
2017-06-27 16:38 ` Leo Li [this message]
2017-05-05 6:01 ` [PATCH v2] " Karim Eshapa
2017-05-05 6:33 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0401MB1699F4CD65C50361933D2FA48FDC0@AM4PR0401MB1699.eurprd04.prod.outlook.com \
--to=leoyang.li@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.king@canonical.com \
--cc=karim.eshapa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=roy.pledge@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).