From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbcHIKjO (ORCPT ); Tue, 9 Aug 2016 06:39:14 -0400 Received: from mail-ve1eur01on0069.outbound.protection.outlook.com ([104.47.1.69]:55120 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751414AbcHIKjL convert rfc822-to-8bit (ORCPT ); Tue, 9 Aug 2016 06:39:11 -0400 X-Greylist: delayed 68828 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Aug 2016 06:39:11 EDT From: york sun To: Borislav Petkov CC: "linux-edac@vger.kernel.org" , "morbidrsa@gmail.com" , "oss@buserror.net" , Stuart Yoder , Doug Thompson , "mchehab@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 Thread-Topic: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 Thread-Index: AQHR7qPRO5gWpMKNpU21i0y3cflLOA== Date: Tue, 9 Aug 2016 05:06:39 +0000 Message-ID: References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-4-git-send-email-york.sun@nxp.com> <20160808071111.GB20800@nazgul.tnic> <20160809033204.GA11445@nazgul.tnic> <20160809050109.GA18922@nazgul.tnic> Reply-To: york sun Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=york.sun@nxp.com; x-originating-ip: [192.88.158.1] x-ms-office365-filtering-correlation-id: b99305f7-5708-48c5-3001-08d3c012f297 x-microsoft-exchange-diagnostics: 1;AM4PR0401MB1730;6:HXcK/zSA2upqCOGWp8rIWsP1We0aiNK+HT5XaQWHkHPzMYRuavh5EfTanPldEnWIj4sqHFP0D1Tj6qAqyvHMonm/ZRD5sPfc+Pus0MEEncj3MBgCX9jxJRGPbbOnh6e4UmDfu/ft0XCEF7Jb7EgwSotrSI7glt8BuhoVDUXLYZXRf3zaCyxSXKR8RWsbbWzb0ZlvRxQsQLHul7ZZuA5ckRVqCA8viFJpOxD5jMNRLHUGQzXxX+4NxbvGgnkOh93z4foK3yhOcg021h7JMWk50n+vLyYWJzYGwrWHvxpU42kYiT4kPJtzPAOVaTXaE6RGd5BkBe5J2A/VD+A3BZyJOA==;5:n/sP2dFBpJFDGiS8hbWroG8Qcw88cqE9H9H/1DbzJ6mbmaMRSEd+dDI0fkA93mmj+2t2JPaU4Jccw/wIm2lZCQgLTYUOUHC1wq6SjksWOYU9ATS6zbbcLQnbMAJjGHaREvRETIPx58Kh3HT3KAhSvQ==;24:RbpHBidpq7rngM/nebp3wEQoX0ik9Gm+y0WrFqP2s5kvYd5TAuaVsD86sc7x/2rX3MNFTaUPEpYD+Ako5oF9XWkFxE3DDDcWAz+QQ3wuWmo=;7:ETuwbRwa8aDSkFO8MfToWgE71Wkx21KpHDtU+yByTXkQ5KWsDeokKahinHoNx0sR2UKhncB09BnL061qpFdTuT7GzpuKgB+OPwacNlDYHMNU794LMEgrr5Ly28g4PPtuCnJmBfH3g3MyabQ02QCVFBaloh3xG8dXrIWgArWy+hndzLTWfowE45dMw+Ip8aeo/SkJGQCBiaswqB0IqD6qdCXXk6SRUtPlnCL2PguJt/NMqd88NL2MpZpjpsZT2NxC x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1730; x-nips-smtp-inbound: xFSL-EDGE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(20558992708506); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:AM4PR0401MB1730;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1730; x-forefront-prvs: 0029F17A3F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(57704003)(199003)(24454002)(189002)(377454003)(3450700001)(3280700002)(3660700001)(106116001)(105586002)(87936001)(106356001)(4326007)(10400500002)(189998001)(7846002)(74316002)(97736004)(86362001)(86152002)(305945005)(7696003)(93886004)(7736002)(2906002)(9686002)(586003)(110136002)(33656002)(2900100001)(8676002)(101416001)(76576001)(68736007)(8936002)(77096005)(43066003)(122556002)(81166006)(81156014)(76176999)(54356999)(53806999)(3846002)(102836003)(5002640100001)(50986999)(66066001)(6116002)(21314002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0401MB1730;H:AM4PR0401MB1732.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2016 05:06:39.9339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB1730 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2016 10:01 PM, Borislav Petkov wrote: > On Tue, Aug 09, 2016 at 04:31:19AM +0000, york sun wrote: >> Yes, for most SoCs RFXE remains cleared. Uncorrectable errors are >> handled by EDAC. > > And how is mpc85_xxx EDAC handling them? > > mpc85xx_mc_check() only reports them. Correct. It can only report this kind of error. It is not correctable. Nothing more can be done. > > And now to get to my original question: is it *enough* to report > uncorrectable errors on those platforms or do they need more > sophisticated error handling in order to disable data corruption? > It is uncorrectable. DDR controller can only report the error. I don't believe EDAC driver can do more. For the same reason I said we can leave RXFE as is, even for e500v1 case (with RIO or PCI is enabled). Nothing can be done with uncorrectable error. York