From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3002549AbcHEVwc (ORCPT ); Fri, 5 Aug 2016 17:52:32 -0400 Received: from mail-db5eur01on0064.outbound.protection.outlook.com ([104.47.2.64]:14064 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1951357AbcHEVwX convert rfc822-to-8bit (ORCPT ); Fri, 5 Aug 2016 17:52:23 -0400 From: york sun To: Scott Wood , Michael Ellerman , "linux-edac@vger.kernel.org" CC: "morbidrsa@gmail.com" , Stuart Yoder , "bp@alien8.de" , Benjamin Herrenschmidt , Paul Mackerras , Kevin Hao , Andrew Donnellan , Yinghai Lu , Bjorn Helgaas , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Thread-Topic: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Thread-Index: AQHR7qPHF5c3qCDX+0ibXYlp7YHgJw== Date: Fri, 5 Aug 2016 21:20:03 +0000 Message-ID: References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-2-git-send-email-york.sun@nxp.com> <877fbvkhi3.fsf@concordia.ellerman.id.au> <1470431358.25630.249.camel@buserror.net> Reply-To: york sun Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=york.sun@nxp.com; x-originating-ip: [192.88.158.2] x-ms-office365-filtering-correlation-id: b53d9fd7-cb8e-4b34-8fd9-08d3bd76445e x-microsoft-exchange-diagnostics: 1;AM4PR0401MB1730;6:v2tZaeOS3aB+YQTTpbZRxvgTcjmQaSJ4G+weaE55gZPTwaj6CKrIRyJurYAI67fb3Owombg9g6I1lny5WLiXInchMOJRauwU6AMDwCUBC0scvTRKWTdFi4UM/r26VbagZp+9toVspawDFXvkHWBKg02rQFjUpw7/ONBHzLAAtPLDMQyI4SECc/y4SccUj7mKv15Sa13k0xmwWRQ0yfT8KgLl+9UFslxB/LeccQDkZV7QeJRMrKnPkjPxQjxR8/41BKEkXWSZApUZaKgWDU77svOa4itP97Wfyw/wwCNqufcZqAk1HgHf24F+TE7A/3GXaQuwtRMH/I8oZXIbj81aDw==;5:4Gt5MISVF28Mv2lmt6An1ueQ2wXAXzFOchUru/2wjjIcO13CTC5W4juGDeN3+6vgnCVv4+LXZajCkYNzaTkxQZH2QY8+kyIfmOp6RtAnAqiy7F2/xJcvw4ZTjgiQ735xIqQd/CJKL/cp2iW399dQRw==;24:4H1pgNLpsxOTSAeO5viG48pNQhp5kL7/cDSZGCD5NjeT0C9E9tyMl0u2t414ms9TSIYMKqM6hK5Po9Wfua6Y1E53HszC9JDms/PSRKuAsHg=;7:fTYPBPxYMMOMtnud2X7HkwI7+DwnhFNPVpb8uj1FXID2N6voeCEunHWI0xhVMBRz1TU/E1WEyQ6lqJfbZo8KjTPJq1siXha+ZrcfRYrF9Hde076qlJ1EYCF5TK77i05PnVoAO6TEg8eJ2vJGlzefmWbwD+D4u+49PlhGlfOxaZlOxjH4tUD6L7JW38c6sj+YquyREVqrVHiDffilnIRHBvc6nFpeE7widQOkIZfGrQAw1DQcQiA3EIp9q7jiOFPk x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1730; x-nips-smtp-inbound: xFSL-EDGE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:AM4PR0401MB1730;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0401MB1730; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(24454002)(377424004)(377454003)(199003)(102836003)(76576001)(101416001)(3280700002)(6116002)(74316002)(7696003)(81156014)(5002640100001)(86362001)(122556002)(3660700001)(43066003)(8676002)(7416002)(8936002)(93886004)(81166006)(7736002)(305945005)(4326007)(3450700001)(11100500001)(10400500002)(2501003)(68736007)(9686002)(189998001)(76176999)(87936001)(50986999)(105586002)(2906002)(66066001)(586003)(5001770100001)(77096005)(54356999)(3846002)(53806999)(86152002)(33656002)(2900100001)(106356001)(7846002)(97736004)(106116001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0401MB1730;H:AM4PR0401MB1732.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2016 21:20:03.8529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB1730 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2016 02:09 PM, Scott Wood wrote: > On Fri, 2016-08-05 at 20:29 +0000, york sun wrote: >> On 08/04/2016 08:43 PM, Michael Ellerman wrote: >>> >>> Does the driver really need to use these routines? They're meant for use >>> early in boot, before PCI is setup. >>> >>> AFAICS this is just a regular driver, so when it's probed the PCI >>> devices should have already been scanned. In which case pci_get_device() >>> could work couldn't it? (I see other edac drivers doing that). >> I am trying to fix this but need some help. We are dealing with PCIe >> controller here. Does it have a bus number assigned at this point? If >> yes, how can I find it? I seem not able to find out where the >> platform_data is filled as well. Can someone kindly point it out to me? > > > The platform data comes from add_err_dev() in arch/powerpc/sysdev/fsl_pci.c. > Thanks, Scott. When add_err_dev() is called, pci is not scanned, is using early_find_capability() justified? York