From: Madalin-Cristian Bucur <madalin.bucur@nxp.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Scott Wood <scott.wood@nxp.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Subject: RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[]
Date: Mon, 19 Dec 2016 16:07:45 +0000 [thread overview]
Message-ID: <AM4PR04MB16044EBA36B62CBA1CEB5C96EC910@AM4PR04MB1604.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20161219.103712.1578523196484939315.davem@davemloft.net>
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, December 19, 2016 5:37 PM
>
> From: Madalin Bucur <madalin.bucur@nxp.com>
> Date: Mon, 19 Dec 2016 11:22:20 +0200
>
> > The fsl/fman drivers will use of_platform_populate() on all
> > supported platforms.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> It seems that this creates a failure point between patches #2 and
> #3. If the cases handled by this "fsl,fman" entry are only afterwards
> covered by the of_platform_populate() code added in patch #3 then you
> cannot split these two changes up like this.
>
> The two changes must be done at the same time, otherwise probing will
> fail for some people between patches #2 and #3.
You are right, that will happen. I was not convinced these need to be
merged due to the different places they touch. I'll send a v3.
next prev parent reply other threads:[~2016-12-19 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 9:22 [PATCH net v2 0/5] fsl/fman: fixes for ARM Madalin Bucur
2016-12-19 9:22 ` [PATCH net v2 1/5] fsl/fman: fix 1G support for QSGMII interfaces Madalin Bucur
2016-12-19 9:22 ` [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[] Madalin Bucur
2016-12-19 15:37 ` David Miller
2016-12-19 16:07 ` Madalin-Cristian Bucur [this message]
2016-12-19 9:22 ` [PATCH net v2 3/5] fsl/fman: call of_platform_populate() Madalin Bucur
2016-12-19 9:22 ` [PATCH net v2 4/5] fsl/fman: A007273 only applies to PPC SoCs Madalin Bucur
2016-12-19 9:22 ` [PATCH net v2 5/5] fsl/fman: enable compilation on ARM64 Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR04MB16044EBA36B62CBA1CEB5C96EC910@AM4PR04MB1604.eurprd04.prod.outlook.com \
--to=madalin.bucur@nxp.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=scott.wood@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).