From: Bharat Bhushan <bharat.bhushan@nxp.com>
To: Eric Auger <eric.auger@redhat.com>,
"eric.auger.pro@gmail.com" <eric.auger.pro@gmail.com>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"drjones@redhat.com" <drjones@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pranav.sawargaonkar@gmail.com" <pranav.sawargaonkar@gmail.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"punit.agrawal@arm.com" <punit.agrawal@arm.com>,
Diana Madalina Craciun <diana.craciun@nxp.com>,
"gpkulkarni@gmail.com" <gpkulkarni@gmail.com>,
"shankerd@codeaurora.org" <shankerd@codeaurora.org>,
"geethasowjanya.akula@gmail.com" <geethasowjanya.akula@gmail.com>
Subject: RE: [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain level
Date: Fri, 6 Jan 2017 08:50:20 +0000 [thread overview]
Message-ID: <AM5PR0401MB25454B0C8F6E610A50B299D19A630@AM5PR0401MB2545.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1483643086-2883-18-git-send-email-eric.auger@redhat.com>
Hi Eric,
> -----Original Message-----
> From: Eric Auger [mailto:eric.auger@redhat.com]
> Sent: Friday, January 06, 2017 12:35 AM
> To: eric.auger@redhat.com; eric.auger.pro@gmail.com;
> christoffer.dall@linaro.org; marc.zyngier@arm.com;
> robin.murphy@arm.com; alex.williamson@redhat.com;
> will.deacon@arm.com; joro@8bytes.org; tglx@linutronix.de;
> jason@lakedaemon.net; linux-arm-kernel@lists.infradead.org
> Cc: kvm@vger.kernel.org; drjones@redhat.com; linux-
> kernel@vger.kernel.org; pranav.sawargaonkar@gmail.com;
> iommu@lists.linux-foundation.org; punit.agrawal@arm.com; Diana Madalina
> Craciun <diana.craciun@nxp.com>; gpkulkarni@gmail.com;
> shankerd@codeaurora.org; Bharat Bhushan <bharat.bhushan@nxp.com>;
> geethasowjanya.akula@gmail.com
> Subject: [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain
> level
>
> In case the IOMMU translates MSI transactions (typical case on ARM), we
> check MSI remapping capability at IRQ domain level. Otherwise it is checked
> at IOMMU level.
>
> At this stage the arm-smmu-(v3) still advertise the
> IOMMU_CAP_INTR_REMAP capability at IOMMU level. This will be removed
> in subsequent patches.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> ---
>
> v6: rewrite test
> ---
> drivers/vfio/vfio_iommu_type1.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_type1.c
> b/drivers/vfio/vfio_iommu_type1.c index b473ef80..fa0b5c4 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -40,6 +40,7 @@
> #include <linux/mdev.h>
> #include <linux/notifier.h>
> #include <linux/dma-iommu.h>
> +#include <linux/irqdomain.h>
>
> #define DRIVER_VERSION "0.2"
> #define DRIVER_AUTHOR "Alex Williamson
> <alex.williamson@redhat.com>"
> @@ -1208,7 +1209,7 @@ static int vfio_iommu_type1_attach_group(void
> *iommu_data,
> struct vfio_domain *domain, *d;
> struct bus_type *bus = NULL, *mdev_bus;
> int ret;
> - bool resv_msi;
> + bool resv_msi, msi_remap;
> phys_addr_t resv_msi_base;
>
> mutex_lock(&iommu->lock);
> @@ -1284,8 +1285,10 @@ static int vfio_iommu_type1_attach_group(void
> *iommu_data,
> INIT_LIST_HEAD(&domain->group_list);
> list_add(&group->next, &domain->group_list);
>
> - if (!allow_unsafe_interrupts &&
> - !iommu_capable(bus, IOMMU_CAP_INTR_REMAP)) {
> + msi_remap = resv_msi ? irq_domain_check_msi_remap() :
There can be multiple interrupt-controller, at-least theoretically it is possible and not sure practically it exists and supported, where not all may support IRQ_REMAP. If that is the case be then should we check for IRQ-REMAP for that device-bus irq-domain?
Thanks
-Bharat
> + iommu_capable(bus,
> IOMMU_CAP_INTR_REMAP);
> +
> + if (!allow_unsafe_interrupts && !msi_remap) {
> pr_warn("%s: No interrupt remapping support. Use the
> module param \"allow_unsafe_interrupts\" to enable VFIO IOMMU support
> on this platform\n",
> __func__);
> ret = -EPERM;
> --
> 1.9.1
next prev parent reply other threads:[~2017-01-06 8:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:04 [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-06 10:59 ` Joerg Roedel
2017-01-06 11:46 ` Auger Eric
2017-01-06 12:12 ` Robin Murphy
2017-01-06 13:05 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 02/18] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 03/18] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-05 19:04 ` [PATCH v6 04/18] iommu: iommu_alloc_resv_region Eric Auger
2017-01-05 19:04 ` [PATCH v6 05/18] iommu: Only map direct mapped regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 06/18] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 07/18] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-06 11:00 ` Joerg Roedel
2017-01-06 11:46 ` Auger Eric
2017-01-06 12:48 ` Joerg Roedel
2017-01-06 13:04 ` Auger Eric
2017-01-06 17:18 ` Auger Eric
2017-01-08 16:26 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 08/18] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-06 11:01 ` Joerg Roedel
2017-01-06 11:45 ` Auger Eric
2017-01-06 12:46 ` Joerg Roedel
2017-01-06 13:03 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 09/18] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 10/18] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-05 19:04 ` [PATCH v6 11/18] iommu/arm-smmu-v3: " Eric Auger
2017-01-05 19:04 ` [PATCH v6 12/18] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-05 19:04 ` [PATCH v6 13/18] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-05 19:04 ` [PATCH v6 14/18] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-05 19:04 ` [PATCH v6 15/18] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-05 19:04 ` [PATCH v6 16/18] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-05 19:04 ` [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain level Eric Auger
2017-01-06 8:50 ` Bharat Bhushan [this message]
2017-01-06 9:08 ` Auger Eric
2017-01-06 9:20 ` Marc Zyngier
2017-01-06 9:31 ` Bharat Bhushan
2017-01-05 19:04 ` [PATCH v6 18/18] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-06 11:02 ` [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0401MB25454B0C8F6E610A50B299D19A630@AM5PR0401MB2545.eurprd04.prod.outlook.com \
--to=bharat.bhushan@nxp.com \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@nxp.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=geethasowjanya.akula@gmail.com \
--cc=gpkulkarni@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pranav.sawargaonkar@gmail.com \
--cc=punit.agrawal@arm.com \
--cc=robin.murphy@arm.com \
--cc=shankerd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).