From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbdLFCRp (ORCPT ); Tue, 5 Dec 2017 21:17:45 -0500 Received: from mail-ve1eur01on0087.outbound.protection.outlook.com ([104.47.1.87]:24536 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753333AbdLFCRj (ORCPT ); Tue, 5 Dec 2017 21:17:39 -0500 From: "Z.q. Hou" To: Cyrille Pitchen , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "boris.brezillon@free-electrons.com" , "marek.vasut@gmail.com" , "richard@nod.at" Subject: RE: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash Thread-Topic: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash Thread-Index: AQHTbY0yy+zaGmnKf0qhKPUpagEllqM1N5WAgABc7MA= Date: Wed, 6 Dec 2017 02:17:36 +0000 Message-ID: References: <20171205053322.35823-1-Zhiqiang.Hou@nxp.com> <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr> In-Reply-To: <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhiqiang.hou@nxp.com; x-originating-ip: [199.59.225.131] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM5PR0402MB2769;6:c0JBSuu9Wu5qDhq3OmTpYNREhSbdkJ0uuB66CLLD4HgOE5Pxok1gYRSV10jgwrCGARZ2FPXzyFRM1ruK5i1vdUaUWw4bthUlsQuNCXlY9hWF+fqe1aZ/yuWoHVdxCTlowS4idyFWRvEQXV09S65J6tEyGCOxzyKfvS6Oi2MOEJD3wAmCrnhrp9084AQiJL0TANm8cI5FpipHJ6r/iHpBrPTYPdlE2JI/L1kr+OlqEcNWujeUlVNUbkueHw8mMO2slctOtr4AdlwLSOgQVJzzLuvRt15BPfDGozFI9Z49sFWUAPhoUzek3cCxQPvXgtfPOdyCiVL87DOiJFtvhCpvp/x7gaVC3Z6ECIQWRK0o9eQ=;5:Ls8OwcRTYthFYHcIeYjXiFH7hXGmraUsTUL0a0jEx9nwzQNUF0biN5GtqkDVlTAfcysoaQssb/KG7cyYqIAHX4HL7nNEZRMO5MW6emv8tx5PalGaMqjgfuXAf1DpSWLG8+Mvo007ytyZzrA8EWOLKFhOlRk5pdqHdrWIjdKLb+w=;24:RHklVKFUbj0WBGG/+mIxBHuyV/M0GGRvAxHQiFcsWp+Sj8mQAYqDTgZwSHLl3gyvr93FASOVnEwQjqeDkH0OlYW8yKkw1XeuP7SYQKQPhbk=;7:8Okla91ar/ozVYrzatGQlxbrVPC/DRvr63cj1PCzddoRg4+3pkmPvleF76kTIiqp1izjz+NpRS1LyoVW1iDAKR8gCRshBUx9DfPOpOwl7rnWyb6BHW3/pBnfS88CoSxA//szhnoQ9GyfOtwht34OM90dc0zC8oiJpAcjQWxDnhP3vFL3t2nsHZ1iG6yQLiLMSdKwKjJJqCjF7c/VzJvRnrt4K3MNmHX+ILzg54PAOGepQ0SriJq0lc2FpVHi6VRg x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4e663e1e-31b5-47e8-8609-08d53c4f847a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286);SRVR:AM5PR0402MB2769; x-ms-traffictypediagnostic: AM5PR0402MB2769: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335)(58145275503218); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231022)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011);SRVR:AM5PR0402MB2769;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM5PR0402MB2769; x-forefront-prvs: 05134F8B4F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(376002)(366004)(346002)(199004)(189003)(13464003)(25786009)(316002)(8936002)(86362001)(2501003)(53546010)(105586002)(106356001)(2906002)(39060400002)(2201001)(6246003)(97736004)(3660700001)(53936002)(6506006)(68736007)(110136005)(9686003)(7696005)(5250100002)(76176011)(2900100001)(5660300001)(3846002)(6116002)(102836003)(3280700002)(101416001)(6436002)(55016002)(81166006)(99286004)(478600001)(2950100002)(81156014)(33656002)(8676002)(305945005)(14454004)(74316002)(229853002)(66066001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0402MB2769;H:AM5PR0402MB2771.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e663e1e-31b5-47e8-8609-08d53c4f847a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2017 02:17:36.4092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2769 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB62HmUi004863 Hi Cyrille, Thanks a lot for your comments! > -----Original Message----- > From: Cyrille Pitchen [mailto:cyrille.pitchen@wedev4u.fr] > Sent: 2017年12月6日 4:41 > To: Z.q. Hou ; linux-mtd@lists.infradead.org; > linux-kernel@vger.kernel.org; computersforpeace@gmail.com; > dwmw2@infradead.org; boris.brezillon@free-electrons.com; > marek.vasut@gmail.com; richard@nod.at > Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when > stop using the flash > > Hi Hou, > > Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit : > > From: Hou Zhiqiang > > > > To be compatible with legacy device, reset the addressing mode to the > > default mode. Such as Freescale eSPI boot, it copies the images from > > SPI flash without firing a reset signal previously, so the reboot > > command will fail without reseting the addressing mode of SPI flash. > > > > You should put this in one of the commit messages so it explains which issue is > fixed by your patches. Agree with you, and will do it in next version. > > Otherwise, your series looks good to me :) > > Best regards, > > Cyrille > > > Hou Zhiqiang (2): > > mtd: spi-nor: add an API to restore the status of SPI flash chip > > mtd: m25p80: restore the status of SPI flash when stop using it > > > > Documentation/mtd/spi-nor.txt | 3 +++ drivers/mtd/devices/m25p80.c > > | 9 +++++++++ drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++ > > include/linux/mtd/spi-nor.h | 6 ++++++ > > 4 files changed, 28 insertions(+) > > Thanks, Zhiqiang