From: Ran Wang <ran.wang_1@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
Date: Tue, 7 May 2019 08:48:31 +0000 [thread overview]
Message-ID: <AM5PR0402MB286539A070BDEEDFC3304F0EF1310@AM5PR0402MB2865.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190501235410.GA25492@bogus>
Hi Rob,
On Thursday, May 02, 2019 07:54 Rob Herring wrote:
>
> On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > This patch adds USB dt nodes for LS1028A.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > Changes in v2:
> > - Rename node from usb3@... to usb@... to meet DTSpec
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> ++++++++++++++++++++
> > 1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 8dd3501..188cfb8 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -144,6 +144,26 @@
> > clocks = <&sysclk>;
> > };
> >
> > + usb0:usb@3100000 {
> ^ space needed
Yes, will update this in next version.
> > + compatible= "snps,dwc3";
>
> Needs an SoC specific compatible.
Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?
As I know, so far there is no SoC specific programming for this IP, so do
you think it's still necessary to add it?
Regards,
Ran
> > + reg= <0x0 0x3100000 0x0 0x10000>;
> > + interrupts= <0 80 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > + usb1:usb@3110000 {
> > + compatible= "snps,dwc3";
> > + reg= <0x0 0x3110000 0x0 0x10000>;
> > + interrupts= <0 81 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > i2c0: i2c@2000000 {
> > compatible = "fsl,vf610-i2c";
> > #address-cells = <1>;
> > --
> > 1.7.1
> >
next prev parent reply other threads:[~2019-05-07 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 5:54 [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes Ran Wang
2019-05-01 23:54 ` Rob Herring
2019-05-07 8:48 ` Ran Wang [this message]
2019-05-07 16:40 ` Rob Herring
2019-05-08 2:20 ` Ran Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0402MB286539A070BDEEDFC3304F0EF1310@AM5PR0402MB2865.eurprd04.prod.outlook.com \
--to=ran.wang_1@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).