From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933466AbcIVOHR (ORCPT ); Thu, 22 Sep 2016 10:07:17 -0400 Received: from mail-db5eur01on0086.outbound.protection.outlook.com ([104.47.2.86]:12896 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751474AbcIVOHO (ORCPT ); Thu, 22 Sep 2016 10:07:14 -0400 From: Vadim Pasternak To: Greg KH CC: "dvhart@infradead.org" , "davem@davemloft.net" , "geert@linux-m68k.org" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "mchehab@kernel.org" , "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Topic: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Index: AQHSFMK0yFEOAYkzuUmQ9j2sM4vq26CFcLoAgAAHHSCAAA0pAIAAAQmA Date: Thu, 22 Sep 2016 13:50:28 +0000 Message-ID: References: <1474550067-142107-1-git-send-email-vadimp@mellanox.com> <20160922123038.GA2630@kroah.com> <20160922134312.GA30274@kroah.com> In-Reply-To: <20160922134312.GA30274@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-office365-filtering-correlation-id: f580f6c3-7ad4-48ac-045b-08d3e2ef6979 x-microsoft-exchange-diagnostics: 1;AM5PR0501MB2100;6:jD+zW0psf5sXFTL2eQjtmcYNxy0cMC02pg2wZYRTOPnREhgCx6jIipfHTL0rzZ91Hjt36peadynXnsiv8vKdsC123/bJv1+qsP/RHjYmZvFIMEJjvU6gkyru4O5OKOe73SddoYYDrGv0HtEF6PACpWSznID6XWXDNq7GA34B8aedBGMkMFyyOWX1jRZn6ykav5N47xPU+Rb2IP4emeJjsG1ctxTUa8zgRzdUQdvTiM0pQdZPSaBBxaL2rqxqK6dHAuOaQAoOBYTlCS2H0/PMTDjTGohSz/Vwy1YC8l2SONDR0BZigxY4rBuDz8sq7eX/MbH1DifPCSHA1D07Q+Ggbw==;5:623Oq/laduUYnBeK3DLeAUWtmlyPsQYD13K+7+kJaKBuPbCL96LVjAUoCXRQeBz7nXRSTrgV+k0QQePG7QnMq9n9yLu8RJ9FClSGrkxTIzk/mfTcwKTbR4j2h7SvikYjGKpLl8jApfb20A4HCcUTrw==;24:XKhaAuKmKnXB7o/NX0icxFAD7onLhwZ1WJazVeQ+8PN9uXjs+nCiS+Fb16RhqMwgDWwoi/VakMmH7S7cyYcDkBHW4nFze4kUb9Os6J+qu5M=;7:e7oxcVaUl6JRhp/94BsKTH6Ga8kLLBflFHeJQpJdKGtRZy/WUG96ePV+qxP1cg7d4rcWghZ0aPobJQgbLl8yxepnuj8pmO6e6lhZ7jqZ/08q8Krrj+sEudXqgEzrgjZuvgUt2UyMF0vtOo6PR4S+TzW+lMxEp7HpBSWgXygcHIhqGUQSMCEXxH0qZmLrlJ0gT4DPxvYTBNe92lScu/t7T/wH6Rx1qpjfL9dUede9deI6hgbheEOQee1R6E5+BG5EKKTlilhmjsRH/uLfb4b4MARy8stPmjccK3ffrOXVKhRqGsFA6WqYay3/B0UF1fe6 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2100; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:AM5PR0501MB2100;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2100; x-forefront-prvs: 0073BFEF03 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(189002)(377454003)(24454002)(13464003)(105586002)(76176999)(2906002)(4326007)(8936002)(86362001)(50986999)(2950100001)(586003)(106356001)(5660300001)(102836003)(7416002)(3846002)(6116002)(54356999)(93886004)(74316002)(2900100001)(97736004)(7696004)(19580405001)(81156014)(110136003)(8676002)(19580395003)(305945005)(101416001)(5002640100001)(106116001)(7736002)(7846002)(77096005)(66066001)(33656002)(76576001)(189998001)(9686002)(81166006)(92566002)(3280700002)(11100500001)(122556002)(87936001)(68736007)(10400500002)(3660700001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0501MB2100;H:AM5PR0501MB2097.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2016 13:50:28.1129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8ME7L6q014884 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, September 22, 2016 4:43 PM > To: Vadim Pasternak > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > x86@vger.kernel.org; jiri@resnulli.us > Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox > hotplug driver > > On Thu, Sep 22, 2016 at 01:01:46PM +0000, Vadim Pasternak wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Thursday, September 22, 2016 3:31 PM > > > To: Vadim Pasternak > > > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > > > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > > > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > > > x86@vger.kernel.org; jiri@resnulli.us > > > Subject: Re: [patch v1] drivers/platform/x86: introduce support for > > > Mellanox hotplug driver > > > > > > On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@mellanox.com wrote: > > > > From: Vadim Pasternak > > > > > > > > Enable system support for the Mellanox Technologies hotplug > > > > platform driver, which provides support for the next Mellanox basic > systems: > > > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > > > > "msb7800", "msn2740", "msn2100" and also various number of > > > > derivative systems from the above basic types. > > > > This driver handles hot-plug events for the power suppliers, power > > > > cables and fans for the above systems. > > > > > > > > The Kconfig currently controlling compilation of this code is: > > > > driver/platform/x86:config MLX_CPLD_PLATFORM > > > > tristate "Mellanox platform hotplug driver support" > > > > > > > > Signed-off-by: Vadim Pasternak > > > > --- > > > > MAINTAINERS | 7 + > > > > drivers/platform/x86/Kconfig | 10 + > > > > drivers/platform/x86/Makefile | 1 + > > > > drivers/platform/x86/mlxcpld-hotplug.c | 543 > > > ++++++++++++++++++++++++++ > > > > include/linux/platform_data/mlxcpld-hotplug.h | 90 +++++ > > > > > > Why do you need a platform_data .h file for a stand-alone driver? > > > > > > > I have another module mlx-platform, which is reviewed now (I also got > > a number feedbacks from you on this matter). I want to activate > > mlxcpld-hotplug from this module. > > Ah. Hm, I thought "platform_data" was depreciated. Really, there is no way to > put this in acpi or device tree? This feels so 1990's... > I can't put in ACPI, since we don't have it. Regarding device tree - I know how to do it for ARM and PPC, but I didn't find some good examples for x86. Maybe you can give me some reference for that? Thanks, Vadim. > thanks, > > greg k-h