From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756725AbcIGPdR (ORCPT ); Wed, 7 Sep 2016 11:33:17 -0400 Received: from mail-db5eur01on0080.outbound.protection.outlook.com ([104.47.2.80]:13369 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751527AbcIGPdP (ORCPT ); Wed, 7 Sep 2016 11:33:15 -0400 X-Greylist: delayed 6801 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Sep 2016 11:33:15 EDT From: Vadim Pasternak To: Jacek Anaszewski , "rpurdie@rpsys.net" CC: "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jiri@resnulli.us" , Michael Shych Subject: RE: [patch] leds: add driver for Mellanox systems leds Thread-Topic: [patch] leds: add driver for Mellanox systems leds Thread-Index: AQHSCPw0sytFxm1E70iiOxYNsrQsMKBt+nAAgAACjDA= Date: Wed, 7 Sep 2016 13:01:28 +0000 Message-ID: References: <1473255323-191745-1-git-send-email-vadimp@mellanox.com> <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> In-Reply-To: <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-office365-filtering-correlation-id: 9a15ba1f-a689-479f-8d3c-08d3d71f1514 x-microsoft-exchange-diagnostics: 1;DB5PR05MB1270;6:ANHTxSuMsTMk0G2m0NB/hNs0osG59HReNN5wBMLFdTeF5mp4tmY7cGkDIorHs7stCLBIcnv2ZuPmZk1b1g7n+swPZ244f+ECFOxAl+ilBu6ebaRWN23sLE4sArxlnc7Eg1EcuroxIpxXOa5HhUVUJt71LYJ24w6mALBJEB0jgPzd2+Erysu4v7w5QQ5eKni2+FxPdFaneflMOc+JCljNrC0eSPMM3WqkMUFbDrlmTQAnC7P4NJOOVCMoaUGjQve452cfqHP9la+vuXjbPhePx2YOjiiuKxZiRbcl1Dj7YI+N9ZfoE7aozuexnSW/pXvFlawNtyPFalMEOMkbwoBt1A==;5:z70O29/nh4U+ySbLWNcjQTyyI7C2m/elCL0g7ta4kyQQLQ0QDANSJ1xHjXkS9M5KytvbM/CteYaD5xI6aM3CEMhZ1IyOCPoKD/8etereMjy1Yzu6tLaUSg+QLRJjZTbk65eyivgkG3jfmhHYBXv/KQ==;24:VRppiYOn1HnGNEQbLlmght+ZlTz3F8defTCbkIlANerxejiqIqgHpvMmlE14HITEpVhqHYEo/N2GGDBSd3hXOZmw1qMBKaX6K1a1z9Va1zI=;7:MQsBUV4ZznIBlDpEehhA/sODsEA9rXYhIKKtqTBbSTuguJthtK9bb+6tgADToeMHDrmlb1pnmjzGqZM234GIpjI8vJVIj9SvRfP9W9gyvdAp0xddIj9WA1Qez4GoYEDu69Zh8gJcFHNJxmk6voZvxX5PU5jM0in/hrVT1iNLNUVtOT2hJSSvN/TyHatOHuQWKcbmZ63QwABlZ0Nk89baWp+XsyCR0mOYR0F10lzH+7t2pbnu9/jFSm0EeExEdS+7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1270; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR05MB1270;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1270; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(51914003)(377454003)(199003)(189002)(13464003)(24454002)(305945005)(7696003)(102836003)(3846002)(9686002)(4001430100002)(5002640100001)(2501003)(189998001)(2950100001)(3660700001)(122556002)(68736007)(586003)(6116002)(106356001)(2900100001)(345774005)(10400500002)(19580395003)(76576001)(3280700002)(76176999)(106116001)(101416001)(54356999)(19580405001)(5660300001)(105586002)(81156014)(81166006)(2906002)(86362001)(74316002)(107886002)(87936001)(8676002)(50986999)(7846002)(8936002)(11100500001)(33656002)(7736002)(66066001)(97736004)(5001770100001)(77096005)(4326007)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1270;H:AM5PR0501MB2097.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 13:01:28.5037 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1270 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u87FXNxs017285 Hi Jacek, Thank you for your comments. > -----Original Message----- > From: Jacek Anaszewski [mailto:j.anaszewski@samsung.com] > Sent: Wednesday, September 07, 2016 3:49 PM > To: Vadim Pasternak ; rpurdie@rpsys.net > Cc: linux-leds@vger.kernel.org; linux-kernel@vger.kernel.org; jiri@resnulli.us; > Michael Shych > Subject: Re: [patch] leds: add driver for Mellanox systems leds > > Hi Vadim, > > On 09/07/2016 03:35 PM, vadimp@mellanox.com wrote: > > From: Vadim Pasternak > > > > This makes it possible to create a set of LEDs for Mellanox systems: > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > > "msb7800", "msn2740", "msn2100". > > > > Driver obtains led devices according to system configuration, provided > > through system DMI data, like fan1:green, fan1:red and creates devices > > in > > form: "devicename:colour:function". > > > > led setting is controlled through on board CPLD Lattice device. > > For setting particular led off, solid, blink (blink requires > > ledtrig-timer module): > > echo 0 > /sys/class/leds/status\:green/brightness > > echo 1 > /sys/class/leds/status\:green/brightness > > echo timer > /sys/class/leds/status\:green/trigger > > > > Thanks for the update, will review it soon. > > One important detail - please update patch version each time you're sending a > new one, like [PATCH v2]. > Will do it in this format next time. Thanks for this input. Best regards, Vadim. > -- > Best regards, > Jacek Anaszewski