From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964813AbcIVN64 (ORCPT ); Thu, 22 Sep 2016 09:58:56 -0400 Received: from mail-db5eur01on0071.outbound.protection.outlook.com ([104.47.2.71]:22112 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751474AbcIVN6r (ORCPT ); Thu, 22 Sep 2016 09:58:47 -0400 From: Vadim Pasternak To: Greg KH CC: "dvhart@infradead.org" , "davem@davemloft.net" , "geert@linux-m68k.org" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "mchehab@kernel.org" , "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Topic: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Index: AQHSFMK0yFEOAYkzuUmQ9j2sM4vq26CFcLoAgAAHHSCAAA0pAIAAAQmAgAABwgCAAAA3IA== Date: Thu, 22 Sep 2016 13:58:43 +0000 Message-ID: References: <1474550067-142107-1-git-send-email-vadimp@mellanox.com> <20160922123038.GA2630@kroah.com> <20160922134312.GA30274@kroah.com> <20160922135312.GA13047@kroah.com> In-Reply-To: <20160922135312.GA13047@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-office365-filtering-correlation-id: c93e9961-6aa3-4f79-d270-08d3e2f090da x-microsoft-exchange-diagnostics: 1;AM5PR0501MB2097;6:hHVmYyDk0NzG4Z6aNNaCG0EjTbgRed7PoWW/qin7fjCc9QnV+rrLsxJR2sGpWfaLkgKGZYeHg7G9Iyd5qtBg3RxxEUo0viM7XTEKwSsdRNcW2H0FOWGclBR14DLTfVnsZz9NmEWhGCXAoKGXgAbKjr+ax2/2wzY8yNvJUeBRsYFgTeqs2wU/I3taxHbqm16uKBqIvv2Gh693VlrDGBeqAvsBY5hoOK1Yba9sJg/lzHqEpwNjBzGHB0q+txE2t+DwL0uNwOeOZihASe+wA8GA2MG2Ppv6g9XuKzHfZSbk4idZInF7tvnMWYuSGRUa8/IQOoXT3+DuzIvHKXsmFnCNig==;5:3MqIWx5IujvZoXUajHTBz8W9cvGWSb73M5DtycBS69Ks8hwoDW3cjwiS/LRz/i8Y5BL1HHYO3XWCp8rNxk8338vl2T2jtvFTk8vC1Mj8IppV6TUu3NArBdgT5ug2f097YHObQ/Ax7l3NrUruyZAJEA==;24:+mZO1P++C2Uri3CGImDc8GgeeQLvKjpLGpo81rozcxym6n9YnmXzdZRJOWr/Tl0Wp6q+71AcFiJzs98g24n40h+/G1vvmkF7G7zLS2kxCx0=;7:9hUqaJKhlzrwLdxwEwVkVpg1xQEHP6ksV9Renl4Qdq3I2HsO8DrxnhBquOLagMfseCpqTGAWYmklaoedF9YTSOvWG9kbz9IbNJ2S3HvLVLVVPJfJJqkmZosNF/ksKkF1ungnnHf2G1rEcNTe9vMacZ4fQP9vraQ78BOCjq+vGBuWCSrtw/QkTchtvfs9+b+JqrEljw9ydsmtrnqoHpRVkxmLQFV2C763dklgmeii2mVB2RinUAWIjmw3o9kB4UzccpQoEgbYXmNxZDcaxqPdlA6siLC1PMSCsQuFVAaWgvKJ200YUZU1nOygLg95JAzZ x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2097; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM5PR0501MB2097;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2097; x-forefront-prvs: 0073BFEF03 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(13464003)(199003)(189002)(377454003)(24454002)(81166006)(586003)(2906002)(19580395003)(122556002)(33656002)(3280700002)(7696004)(92566002)(102836003)(5002640100001)(9686002)(86362001)(2900100001)(19580405001)(76576001)(2950100001)(93886004)(6116002)(10400500002)(3846002)(3660700001)(66066001)(77096005)(5660300001)(50986999)(97736004)(7846002)(87936001)(8676002)(7736002)(68736007)(105586002)(189998001)(81156014)(11100500001)(106356001)(7416002)(74316002)(110136003)(54356999)(305945005)(101416001)(76176999)(4326007)(106116001)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0501MB2097;H:AM5PR0501MB2097.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2016 13:58:43.7017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2097 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8MDx4bM014785 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, September 22, 2016 4:53 PM > To: Vadim Pasternak > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > x86@vger.kernel.org; jiri@resnulli.us > Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox > hotplug driver > > On Thu, Sep 22, 2016 at 01:50:28PM +0000, Vadim Pasternak wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Thursday, September 22, 2016 4:43 PM > > > To: Vadim Pasternak > > > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > > > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > > > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > > > x86@vger.kernel.org; jiri@resnulli.us > > > Subject: Re: [patch v1] drivers/platform/x86: introduce support for > > > Mellanox hotplug driver > > > > > > On Thu, Sep 22, 2016 at 01:01:46PM +0000, Vadim Pasternak wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > Sent: Thursday, September 22, 2016 3:31 PM > > > > > To: Vadim Pasternak > > > > > Cc: dvhart@infradead.org; davem@davemloft.net; > > > > > geert@linux-m68k.org; akpm@linux-foundation.org; > > > > > kvalo@codeaurora.org; mchehab@kernel.org; linux@roeck-us.net; > > > > > linux-kernel@vger.kernel.org; platform-driver- > > > > > x86@vger.kernel.org; jiri@resnulli.us > > > > > Subject: Re: [patch v1] drivers/platform/x86: introduce support > > > > > for Mellanox hotplug driver > > > > > > > > > > On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@mellanox.com > wrote: > > > > > > From: Vadim Pasternak > > > > > > > > > > > > Enable system support for the Mellanox Technologies hotplug > > > > > > platform driver, which provides support for the next Mellanox > > > > > > basic > > > systems: > > > > > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", > > > > > > "msn2410", "msb7800", "msn2740", "msn2100" and also various > > > > > > number of derivative systems from the above basic types. > > > > > > This driver handles hot-plug events for the power suppliers, > > > > > > power cables and fans for the above systems. > > > > > > > > > > > > The Kconfig currently controlling compilation of this code is: > > > > > > driver/platform/x86:config MLX_CPLD_PLATFORM > > > > > > tristate "Mellanox platform hotplug driver support" > > > > > > > > > > > > Signed-off-by: Vadim Pasternak > > > > > > --- > > > > > > MAINTAINERS | 7 + > > > > > > drivers/platform/x86/Kconfig | 10 + > > > > > > drivers/platform/x86/Makefile | 1 + > > > > > > drivers/platform/x86/mlxcpld-hotplug.c | 543 > > > > > ++++++++++++++++++++++++++ > > > > > > include/linux/platform_data/mlxcpld-hotplug.h | 90 +++++ > > > > > > > > > > Why do you need a platform_data .h file for a stand-alone driver? > > > > > > > > > > > > > I have another module mlx-platform, which is reviewed now (I also > > > > got a number feedbacks from you on this matter). I want to > > > > activate mlxcpld-hotplug from this module. > > > > > > Ah. Hm, I thought "platform_data" was depreciated. Really, there > > > is no way to put this in acpi or device tree? This feels so 1990's... > > > > > > > I can't put in ACPI, since we don't have it. > > Regarding device tree - I know how to do it for ARM and PPC, but I didn't find > some good examples for x86. > > Maybe you can give me some reference for that? > > I have no idea, sorry :( I see several not so good " artificial" examples of device tree usage in x86. And folder include/linux/platform_data/ contains about thousand files.