From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Mark Brown <broonie@kernel.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Akshu Agrawal <Akshu.Agrawal@amd.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH 1/3] ASoC: da7219: Update DAI clock binding info to cover WCLK/BCLK
Date: Thu, 21 Mar 2019 14:15:41 +0000 [thread overview]
Message-ID: <AM5PR1001MB0994B0B76F0166D45990E5F980420@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190321122152.GA5684@sirena.org.uk>
On 21 March 2019 12:22, Mark Brown wrote:
> On Tue, Mar 19, 2019 at 05:49:30PM +0000, Adam Thomson wrote:
>
> > -- #clock-cells : Should be set to '<0>', only one clock source
> > provided;
> > -- clock-output-names : Name given for DAI clocks output;
> > +- #clock-cells : Should be set to '<1>', two clock sources provided;
> > +- clock-output-names : Names given for DAI clock outputs (WCLK &
> > +BCLK);
>
> This might need some handling later on as it's a binding change, however I can't
> see any current users so hopefully nobody will notice.
No I do not believe there are users of this, other than the AMD board which
doesn't use these bindings. Actually given they're the same bindings, albeit
with a different number of cells, I've tested the code with just 1 cell and
1 clock in the DTS and this still works as before so the driver should be
backwards compatible.
next prev parent reply other threads:[~2019-03-21 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 17:49 [PATCH 0/3] ASoC: da7219: Extend CCF support to allow WCLK/BCLK config Adam Thomson
2019-03-19 17:49 ` [PATCH 1/3] ASoC: da7219: Update DAI clock binding info to cover WCLK/BCLK Adam Thomson
2019-03-21 12:21 ` Mark Brown
2019-03-21 14:15 ` Adam Thomson [this message]
2019-03-21 15:07 ` Applied "ASoC: da7219: Update DAI clock binding info to cover WCLK/BCLK" to the asoc tree Mark Brown
2019-03-19 17:49 ` [PATCH 2/3] ASoC: da7219: Expose BCLK and WCLK control through CCF Adam Thomson
2019-03-21 15:07 ` Applied "ASoC: da7219: Expose BCLK and WCLK control through CCF" to the asoc tree Mark Brown
2019-03-19 17:49 ` [PATCH 3/3] ASoC: AMD: Update DA7219 DAI clock name to align with codec updates Adam Thomson
2019-03-21 15:07 ` Applied "ASoC: AMD: Update DA7219 DAI clock name to align with codec updates" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR1001MB0994B0B76F0166D45990E5F980420@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Akshu.Agrawal@amd.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).