linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Bara - SKIDATA <Benjamin.Bara@skidata.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"mchehab@kernel.org" <mchehab@kernel.org>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Richard Leitner - SKIDATA <Richard.Leitner@skidata.com>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: RE: [PATCH] media: coda: avoid starvation on well-compressed data
Date: Fri, 18 Sep 2020 08:35:38 +0000	[thread overview]
Message-ID: <AM6PR01MB55741EE09532A7C60CD05B71E23F0@AM6PR01MB5574.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <9444c9375f58436b9e6a0fa3a4088e17@skidata.com>

Hi all,

there are still cases where the decoder starves.
Also, the failure log at the bottom contradicts with the 2x256 bytes assumption.
When I increase the threshold to 512 bytes, the respective video (and all my other tests) work.

Is it possible that the limitation is 2x512 bytes or is there another "limitation",
beside the "two window" one, which is "accidentally fulfilled" with this approach?

What do you think about the approach in the patch; is it possible to get it mainline?
Any help, feedback, hints or suggestions would be really appreciated!

I will do some additional testing to see if the 2x512 threshold finally catches the problem.
When I'm done, I will provide a second version of the patch.

Many thanks & best regards
Benjamin

*Failure Log:*
[  108.108711] coda 2040000.vpu: 0: active metas:
[  108.108716] coda 2040000.vpu: 0: - payload: 4240
[  108.108721] coda 2040000.vpu: 0: - payload: 900
[  108.108726] coda 2040000.vpu: 0: - payload: 170
[  108.108730] coda 2040000.vpu: 0: - payload: 403
[  108.108734] coda 2040000.vpu: 0: want to queue: payload: 405
[  109.057738] coda 2040000.vpu: CODA PIC_RUN timeout


  reply	other threads:[~2020-09-18  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 11:58 [PATCH] media: coda: avoid starvation on well-compressed data Benjamin Bara - SKIDATA
2020-08-21 11:59 ` Benjamin Bara - SKIDATA
2020-09-18  8:35   ` Benjamin Bara - SKIDATA [this message]
2020-09-28 20:06     ` Ezequiel Garcia
2020-10-06 14:56       ` Benjamin Bara - SKIDATA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR01MB55741EE09532A7C60CD05B71E23F0@AM6PR01MB5574.eurprd01.prod.exchangelabs.com \
    --to=benjamin.bara@skidata.com \
    --cc=Richard.Leitner@skidata.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).