From: Aisheng Dong <aisheng.dong@nxp.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Atish Patra <atish.patra@wdc.com>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
Anson Huang <anson.huang@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: RE: [PATCH] imx: select SOC_BUS to fix firmware build
Date: Mon, 18 Jan 2021 04:36:55 +0000 [thread overview]
Message-ID: <AM6PR04MB49666F4A293420EF8E090E8B80A40@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210116033259.31941-1-rdunlap@infradead.org>
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Saturday, January 16, 2021 11:33 AM
> Subject: [PATCH] imx: select SOC_BUS to fix firmware build
Patch title probably is better to be:
firmware: imx: xxxxx
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
>
> Fix build error in firmware/imx/ selecting SOC_BUS.
>
> riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
> imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'
>
> Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Atish Patra <atish.patra@wdc.com>
> Cc: Palmer Dabbelt <palmerdabbelt@google.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Anson Huang <Anson.Huang@nxp.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/firmware/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
> +++ linux-next-20210115/drivers/firmware/imx/Kconfig
> @@ -13,6 +13,7 @@ config IMX_DSP
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> depends on IMX_MBOX
> + select SOC_BUS
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
next prev parent reply other threads:[~2021-01-18 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 3:32 [PATCH] imx: select SOC_BUS to fix firmware build Randy Dunlap
2021-01-18 4:36 ` Aisheng Dong [this message]
2021-01-18 7:47 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB49666F4A293420EF8E090E8B80A40@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=ardb@kernel.org \
--cc=atish.patra@wdc.com \
--cc=daniel.baluta@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=palmerdabbelt@google.com \
--cc=rdunlap@infradead.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).