From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Leo Li <leoyang.li@nxp.com>
Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mingkai Hu <mingkai.hu@nxp.com>,
"M.h. Lian" <minghuan.lian@nxp.com>
Subject: RE: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings
Date: Wed, 7 Nov 2018 04:29:19 +0000 [thread overview]
Message-ID: <AM6PR04MB5781A4335A41AF4DC9D1D87884C40@AM6PR04MB5781.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CADRPPNQRofR6Upe6_pTNm-bqt0HMVWBOXyYSH8xGvD2g7_nwCA@mail.gmail.com>
Hi Leo,
Thanks a lot for your comments!
> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: 2018年10月27日 4:58
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@lists.infradead.org>; lkml <linux-kernel@vger.kernel.org>;
> linux-pci@vger.kernel.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Rob Herring
> <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Bjorn Helgaas <bhelgaas@google.com>; Mingkai
> Hu <mingkai.hu@nxp.com>; M.h. Lian <minghuan.lian@nxp.com>
> Subject: Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller
> compatible strings
>
> On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
>
> The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
> ...", and it should be better to mention the string removed in the title too.
Will correct it in v3.
>
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > Removed the wrong compatible string "snps,dw-pcie", in case match
> > incorrect driver.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > V2:
> > - no change
> >
> > arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index bdd6e66a79ad..1aaa3288a450
> > 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -716,7 +716,7 @@
> > };
> >
> > pcie@3400000 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x03400000 0x0 0x00010000
> /* controller registers */
> > 0x40 0x00000000 0x0 0x00002000>;
> /* configuration space */
> > reg-names = "regs", "config"; @@ -739,7
> +739,7
> > @@
> > };
> >
> > pcie@3500000 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x03500000 0x0 0x00010000
> /* controller registers */
> > 0x48 0x00000000 0x0 0x00002000>;
> /* configuration space */
> > reg-names = "regs", "config";
> > --
> > 2.17.1
> >
Thanks,
Zhiqiang
next prev parent reply other threads:[~2018-11-07 4:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 9:49 [PATCH v2 0/4] dts/layerscape-pci: removed unsuitable compatible string Z.q. Hou
2018-10-25 9:49 ` [PATCH v2 1/4] dt-bindings: pci: layerscape-pci: add compatible strings "fsl,ls1043a-pcie" Z.q. Hou
2018-10-25 21:50 ` Rob Herring
2018-10-25 9:49 ` [PATCH v2 2/4] dt-bindings: pci: layerscape-pci: removed compatible string "snps,dw-pcie" Z.q. Hou
2018-10-25 21:51 ` Rob Herring
2018-10-25 9:49 ` [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings Z.q. Hou
2018-10-26 20:58 ` Li Yang
2018-11-07 4:29 ` Z.q. Hou [this message]
2018-10-25 9:49 ` [PATCH v2 4/4] dts/arm64/layerscape: " Z.q. Hou
2018-10-26 21:00 ` Li Yang
2018-11-07 4:30 ` Z.q. Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB5781A4335A41AF4DC9D1D87884C40@AM6PR04MB5781.eurprd04.prod.outlook.com \
--to=zhiqiang.hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).