linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alice Guo (OSS)" <alice.guo@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"Alice Guo (OSS)" <alice.guo@oss.nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID
Date: Fri, 18 Dec 2020 10:14:35 +0000	[thread overview]
Message-ID: <AM6PR04MB60534C972777EED96FD105D2E2C30@AM6PR04MB6053.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20201218093641.GA38684@kozik-lap>



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 2020年12月18日 17:37
> To: Alice Guo (OSS) <alice.guo@oss.nxp.com>
> Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc
> unique ID
> 
> On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote:
>  > > +    required:
> > > > +      - compatible
> > > > +      - nvmem-cells
> > > > +      - nvmem-cell-names
> > > > +
> > > > +additionalProperties: true
> > >
> > > Don't leave comments unresolved (or resolve them against review
> > > without discussion). Rob asked for changing it. The same as with all
> > > schemas - you need to describe the missing properties.
> > >
> > > Best regards,
> > > Krzysztof
> >
> > Hi,
> > Thank you for your advice. I replied to him and let him know I remained here
> unchanged. There will be errors according to his suggestion.
> 
> Then the solution is to correct the errors - describe missing properties
> - instead of ignoring the suggestion and making a resubmit right away.
> 
> Best regards,
> Krzysztof

Hi,
I am sorry I do not DT Binding doc very well.

I checked the usage of patternProperties and additionalProperties in https://json-schema.org/understanding-json-schema/reference/object.html.
I noticed a sentence on the website: " If additionalProperties is a boolean and set to false, no additional properties will be allowed.", so I think that
if additionalProperties is a boolean and set to true, additional properties will be allowed. Letting here unchanged is my solution to correct the errors.
I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to me, so I made a resubmit.

Thank you for your comment again.

Best regards,
Alice


  reply	other threads:[~2020-12-18 10:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  8:37 [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo (OSS)
2020-12-18  8:37 ` [PATCH v8 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo (OSS)
2020-12-18  8:37 ` [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo (OSS)
2020-12-19 12:16   ` Krzysztof Kozlowski
2020-12-21  3:10     ` Alice Guo (OSS)
2020-12-21  7:56       ` Krzysztof Kozlowski
2020-12-18  8:37 ` [PATCH v8 4/4] soc: imx8m: change to use platform driver Alice Guo (OSS)
2020-12-19 12:18   ` Krzysztof Kozlowski
2020-12-21  2:36     ` Alice Guo (OSS)
2020-12-18  8:52 ` [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-12-18  9:05   ` Alice Guo (OSS)
2020-12-18  9:36     ` Krzysztof Kozlowski
2020-12-18 10:14       ` Alice Guo (OSS) [this message]
2020-12-18 13:59         ` Rob Herring
2020-12-21  9:20           ` Alice Guo (OSS)
2020-12-21 20:29             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB60534C972777EED96FD105D2E2C30@AM6PR04MB6053.eurprd04.prod.outlook.com \
    --to=alice.guo@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).