linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Qian <ming.qian@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	dl-linux-imx <linux-imx@nxp.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v10 01/13] dt-bindings: media: amphion: add amphion video codec bindings
Date: Thu, 14 Oct 2021 02:14:42 +0000	[thread overview]
Message-ID: <AM6PR04MB63414498641CD4F128EE63B6E7B89@AM6PR04MB6341.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1634150392.524588.1324762.nullmailer@robh.at.kernel.org>

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Thursday, October 14, 2021 2:40 AM
> To: Ming Qian <ming.qian@nxp.com>
> Cc: shawnguo@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>;
> s.hauer@pengutronix.de; robh+dt@kernel.org; festevam@gmail.com;
> hverkuil-cisco@xs4all.nl; dl-linux-imx <linux-imx@nxp.com>;
> mchehab@kernel.org; linux-media@vger.kernel.org; kernel@pengutronix.de;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v10 01/13] dt-bindings: media: amphion: add
> amphion video codec bindings
> 
> Caution: EXT Email
> 
> On Wed, 13 Oct 2021 16:27:17 +0800, Ming Qian wrote:
> > Add devicetree binding documentation for amphion Video Processing Unit
> > IP presents on NXP i.MX8Q
> >
> > Signed-off-by: Ming Qian <ming.qian@nxp.com>
> > Signed-off-by: Shijie Qin <shijie.qin@nxp.com>
> > Signed-off-by: Zhou Peng <eagle.zhou@nxp.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/media/amphion,vpu.yaml           | 178
> ++++++++++++++++++
> >  1 file changed, 178 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/amphion,vpu.yaml
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media
> /amphion,vpu.yaml:
> patternProperties:^vpu_core@[0-9a-f]+$:properties:compatible:oneOf:
> [{'const': 'nxp,imx8q-vpu-decoder'}, {'const': 'nxp,imx8q-vpu-encoder'}] should
> not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required':
> ['const']}}
>         hint: Use 'enum' rather than 'oneOf' + 'const' entries
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr
> ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&amp;data=04%7C01%7Cmin
> g.qian%40nxp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=fOAy2B6rSge9vUFFMXg1CWuDD
> UVqapcDxEMH0DOIcbI%3D&amp;reserved=0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media
> /amphion,vpu.yaml: properties:compatible:oneOf: [{'const':
> 'nxp,imx8qm-vpu'}, {'const': 'nxp,imx8qxp-vpu'}] should not be valid under
> {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
>         hint: Use 'enum' rather than 'oneOf' + 'const' entries
>         from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr
> ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&amp;data=04%7C01%7Cmin
> g.qian%40nxp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=fOAy2B6rSge9vUFFMXg1CWuDD
> UVqapcDxEMH0DOIcbI%3D&amp;reserved=0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media
> /amphion,vpu.yaml: ignoring, error in schema: patternProperties:
> ^vpu_core@[0-9a-f]+$: properties: compatible: oneOf
> warning: no schema found in
> file: ./Documentation/devicetree/bindings/media/amphion,vpu.yaml
> Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0:
> /example-0/vpu@2c000000: failed to match any schema with compatible:
> ['nxp,imx8qm-vpu']
> Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0:
> /example-0/vpu@2c000000/vpu_core@2d080000: failed to match any
> schema with compatible: ['nxp,imx8q-vpu-decoder']
> Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0:
> /example-0/vpu@2c000000/vpu_core@2d090000: failed to match any
> schema with compatible: ['nxp,imx8q-vpu-encoder']
> Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0:
> /example-0/vpu@2c000000/vpu_core@2d0a0000: failed to match any
> schema with compatible: ['nxp,imx8q-vpu-encoder']
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fpatch%2F1540273&amp;data=04%7C01%7Cming.qian%40n
> xp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C1000&amp;sdata=VZB1wJBe3b4WMHdhPVqlqZDoNRcui2mk0
> VYAN4NbXDU%3D&amp;reserved=0
> 
> This check can fail if there are any dependencies. The base for a patch series is
> generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.

I meet the error after upgrade dtschema, I'll fix it and submit again


  reply	other threads:[~2021-10-14  2:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  8:27 [PATCH v10 00/13] amphion video decoder/encoder driver Ming Qian
2021-10-13  8:27 ` [PATCH v10 01/13] dt-bindings: media: amphion: add amphion video codec bindings Ming Qian
2021-10-13 18:39   ` Rob Herring
2021-10-14  2:14     ` Ming Qian [this message]
2021-10-13  8:27 ` [PATCH v10 02/13] media:Add nv12mt_8l128 and nv12mt_10be_8l128 video format Ming Qian
2021-10-13  8:27 ` [PATCH v10 03/13] media: amphion: add amphion vpu device driver Ming Qian
2021-10-13 22:16   ` Randy Dunlap
2021-10-14  1:49     ` [EXT] " Ming Qian
2021-10-13  8:27 ` [PATCH v10 04/13] media: amphion: add vpu core driver Ming Qian
2021-10-13  8:27 ` [PATCH v10 05/13] media: amphion: implement vpu core communication based on mailbox Ming Qian
2021-10-13  8:27 ` [PATCH v10 06/13] media: amphion: add vpu v4l2 m2m support Ming Qian
2021-10-13  8:27 ` [PATCH v10 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver Ming Qian
2021-10-13  8:27 ` [PATCH v10 08/13] media: amphion: add v4l2 m2m vpu decoder " Ming Qian
2021-10-13  8:27 ` [PATCH v10 09/13] media: amphion: implement windsor encoder rpc interface Ming Qian
2021-10-13  8:27 ` [PATCH v10 10/13] media: amphion: implement malone decoder " Ming Qian
2021-10-13  8:27 ` [PATCH v10 11/13] ARM64: dts: freescale: imx8q: add imx vpu codec entries Ming Qian
2021-10-13  8:27 ` [PATCH v10 12/13] firmware: imx: scu-pd: imx8q: add vpu mu resources Ming Qian
2021-10-13  8:27 ` [PATCH v10 13/13] MAINTAINERS: add AMPHION VPU CODEC V4L2 driver entry Ming Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB63414498641CD4F128EE63B6E7B89@AM6PR04MB6341.eurprd04.prod.outlook.com \
    --to=ming.qian@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).