From: Justin He <Justin.He@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: James Morse <James.Morse@arm.com>,
Alexandru Elisei <Alexandru.Elisei@arm.com>,
Suzuki Poulose <Suzuki.Poulose@arm.com>,
Oliver Upton <oupton@google.com>,
Xiaoming Ni <nixiaoming@huawei.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Kees Cook <keescook@chromium.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liu Shixin <liushixin2@huawei.com>,
Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, nd <nd@arm.com>
Subject: RE: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations
Date: Wed, 13 Oct 2021 09:01:24 +0000 [thread overview]
Message-ID: <AM6PR08MB437604FBA3C47C4D70D2A9CDF7B79@AM6PR08MB4376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAOQ_QshF+N7Q=-cXAoMSW4Gcy7mr_oFVpye7fEBqPeR8+3mK0Q@mail.gmail.com>
Hi Marc
> -----Original Message-----
> From: Oliver Upton <oupton@google.com>
> Sent: Monday, September 13, 2021 8:21 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>; James Morse <James.Morse@arm.com>;
> Alexandru Elisei <Alexandru.Elisei@arm.com>; Suzuki Poulose
> <Suzuki.Poulose@arm.com>; Xiaoming Ni <nixiaoming@huawei.com>; Lorenzo
> Pieralisi <Lorenzo.Pieralisi@arm.com>; Kees Cook <keescook@chromium.org>;
> Catalin Marinas <Catalin.Marinas@arm.com>; Nick Desaulniers
> <ndesaulniers@google.com>; linux-kernel@vger.kernel.org; Liu Shixin
> <liushixin2@huawei.com>; Sami Tolvanen <samitolvanen@google.com>; Will
> Deacon <will@kernel.org>; kvmarm@lists.cs.columbia.edu; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM
> allocations
>
[...]
> > Do you mean kvm_hyp_zalloc_page() here?
> > Seems kvm_hyp_zalloc_page() is in both global and VM scopes.
>
> Doh! kvm_hyp_zalloc_page() is only for the hyp's page tables, hence I
> believe your patch is correct as it stands. As such:
>
> Reviewed-by: Oliver Upton <oupton@google.com>
Kindly ping for the whole series. 😉
--
Cheers,
Justin (Jia He)
next prev parent reply other threads:[~2021-10-13 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:31 [PATCH v2 0/2] Add memcg accounting to Arm KVM Jia He
2021-09-07 12:31 ` [PATCH v2 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations Jia He
2021-09-08 1:21 ` Oliver Upton
2021-09-07 12:31 ` [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations Jia He
2021-09-07 22:29 ` Oliver Upton
2021-09-09 12:56 ` Justin He
2021-09-13 12:21 ` Oliver Upton
2021-10-13 9:01 ` Justin He [this message]
2021-10-17 10:30 ` [PATCH v2 0/2] Add memcg accounting to Arm KVM Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB437604FBA3C47C4D70D2A9CDF7B79@AM6PR08MB4376.eurprd08.prod.outlook.com \
--to=justin.he@arm.com \
--cc=Alexandru.Elisei@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=James.Morse@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=keescook@chromium.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=ndesaulniers@google.com \
--cc=nixiaoming@huawei.com \
--cc=oupton@google.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).