From: Justin He <Justin.He@arm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Eric Biggers <ebiggers@google.com>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>, nd <nd@arm.com>
Subject: RE: [PATCH v5 0/4] make '%pD' print the full path of file
Date: Wed, 23 Jun 2021 04:13:03 +0000 [thread overview]
Message-ID: <AM6PR08MB437633FB7FDF81D8F1A96DCAF7089@AM6PR08MB4376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <YNH3C6P9i7xvapav@smile.fi.intel.com>
Hi Andy
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, June 22, 2021 10:43 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Petr Mladek <pmladek@suse.com>; Steven Rostedt <rostedt@goodmis.org>;
> Sergey Senozhatsky <senozhatsky@chromium.org>; Rasmus Villemoes
> <linux@rasmusvillemoes.dk>; Jonathan Corbet <corbet@lwn.net>; Alexander
> Viro <viro@zeniv.linux.org.uk>; Linus Torvalds <torvalds@linux-
> foundation.org>; Peter Zijlstra (Intel) <peterz@infradead.org>; Eric
> Biggers <ebiggers@google.com>; Ahmed S. Darwish <a.darwish@linutronix.de>;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> fsdevel@vger.kernel.org; Matthew Wilcox <willy@infradead.org>; Christoph
> Hellwig <hch@infradead.org>; nd <nd@arm.com>
> Subject: Re: [PATCH v5 0/4] make '%pD' print the full path of file
>
> On Tue, Jun 22, 2021 at 10:06:30PM +0800, Jia He wrote:
> > Background
> > ==========
> > Linus suggested printing the full path of file instead of printing
> > the components as '%pd'.
> >
> > Typically, there is no need for printk specifiers to take any real locks
> > (ie mount_lock or rename_lock). So I introduce a new helper d_path_fast
> > which is similar to d_path except it doesn't take any seqlock/spinlock.
> >
> > This series is based on Al Viro's d_path cleanup patches [1] which
> > lifted the inner lockless loop into a new helper.
> >
> > Link: https://lkml.org/lkml/2021/5/18/1260 [1]
> >
> > Test
> > ====
> > The cases I tested:
> > 1. print '%pD' with full path of ext4 file
> > 2. mount a ext4 filesystem upon a ext4 filesystem, and print the file
> > with '%pD'
> > 3. all test_print selftests, including the new '%14pD' '%-14pD'
>
> > 4. kasnprintf
>
> I believe you are talking about kasprintf().
>
>
> > Changelog
> > =========
> > v5:
> > - remove the RFC tag
>
> JFYI, when we drop RFC we usually start the series from v1.
>
> > - refine the commit msg/comments(by Petr, Andy)
> > - make using_scratch_space a new parameter of the test case
>
> Thanks for the update, I have found few minor things, please address them
> and
> feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
I assume I can add your R-b to patch 4/4 "add test cases for '%pD'" instead of
whole series, right?
--
Cheers,
Justin (Jia He)
next prev parent reply other threads:[~2021-06-23 4:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:06 [PATCH v5 0/4] make '%pD' print the full path of file Jia He
2021-06-22 14:06 ` [PATCH v5 1/4] fs: introduce helper d_path_unsafe() Jia He
2021-06-22 14:36 ` Andy Shevchenko
2021-06-23 2:02 ` Justin He
2021-06-23 9:07 ` Andy Shevchenko
2021-06-24 2:35 ` Justin He
2021-06-24 9:26 ` Petr Mladek
2021-06-24 10:48 ` Andy Shevchenko
2021-06-22 14:06 ` [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of file Jia He
2021-06-22 14:39 ` Andy Shevchenko
2021-06-23 3:14 ` Justin He
2021-06-24 8:46 ` Petr Mladek
2021-06-24 9:01 ` Justin He
2021-06-22 14:06 ` [PATCH v5 3/4] lib/test_printf.c: split write-beyond-buffer check in two Jia He
2021-06-22 14:06 ` [PATCH v5 4/4] lib/test_printf.c: add test cases for '%pD' Jia He
2021-06-22 14:41 ` Andy Shevchenko
2021-06-22 20:51 ` Rasmus Villemoes
2021-06-23 3:27 ` Justin He
2021-06-22 14:43 ` [PATCH v5 0/4] make '%pD' print the full path of file Andy Shevchenko
2021-06-23 4:13 ` Justin He [this message]
2021-06-23 9:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB437633FB7FDF81D8F1A96DCAF7089@AM6PR08MB4376.eurprd08.prod.outlook.com \
--to=justin.he@arm.com \
--cc=a.darwish@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).