From: Justin He <Justin.He@arm.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Eric Biggers <ebiggers@google.com>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>, nd <nd@arm.com>
Subject: RE: [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full path of file
Date: Fri, 25 Jun 2021 02:32:58 +0000 [thread overview]
Message-ID: <AM6PR08MB4376C621240CD63E215C40EEF7069@AM6PR08MB4376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <AM6PR08MB4376E39649192846F644E785F7069@AM6PR08MB4376.eurprd08.prod.outlook.com>
> -----Original Message-----
> From: Justin He
> Sent: Friday, June 25, 2021 10:30 AM
> To: Petr Mladek <pmladek@suse.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>; Sergey Senozhatsky
> <senozhatsky@chromium.org>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Rasmus Villemoes
> <linux@rasmusvillemoes.dk>; Jonathan Corbet <corbet@lwn.net>; Alexander
> Viro <viro@zeniv.linux.org.uk>; Linus Torvalds <torvalds@linux-
> foundation.org>; Peter Zijlstra (Intel) <peterz@infradead.org>; Eric
> Biggers <ebiggers@google.com>; Ahmed S. Darwish <a.darwish@linutronix.de>;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> fsdevel@vger.kernel.org; Matthew Wilcox <willy@infradead.org>; Christoph
> Hellwig <hch@infradead.org>; nd <nd@arm.com>
> Subject: RE: [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full path
> of file
>
> Hi Petr
>
> > -----Original Message-----
> > From: Petr Mladek <pmladek@suse.com>
> > Sent: Thursday, June 24, 2021 5:02 PM
> > To: Justin He <Justin.He@arm.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>; Sergey Senozhatsky
> > <senozhatsky@chromium.org>; Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com>; Rasmus Villemoes
> > <linux@rasmusvillemoes.dk>; Jonathan Corbet <corbet@lwn.net>; Alexander
> > Viro <viro@zeniv.linux.org.uk>; Linus Torvalds <torvalds@linux-
> > foundation.org>; Peter Zijlstra (Intel) <peterz@infradead.org>; Eric
> > Biggers <ebiggers@google.com>; Ahmed S. Darwish <a.darwish@linutronix.de>;
> > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > fsdevel@vger.kernel.org; Matthew Wilcox <willy@infradead.org>; Christoph
> > Hellwig <hch@infradead.org>; nd <nd@arm.com>
> > Subject: Re: [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full
> path
> > of file
> >
> > On Wed 2021-06-23 13:50:09, Jia He wrote:
> > > Previously, the specifier '%pD' is for printing dentry name of struct
> > > file. It may not be perfect (by default it only prints one component.)
> > >
> > > As suggested by Linus [1]:
> > > > A dentry has a parent, but at the same time, a dentry really does
> > > > inherently have "one name" (and given just the dentry pointers, you
> > > > can't show mount-related parenthood, so in many ways the "show just
> > > > one name" makes sense for "%pd" in ways it doesn't necessarily for
> > > > "%pD"). But while a dentry arguably has that "one primary component",
> > > > a _file_ is certainly not exclusively about that last component.
> > >
> > > Hence change the behavior of '%pD' to print the full path of that file.
> > >
> > > If someone invokes snprintf() with small but positive space,
> > > prepend_name_with_len() moves or truncates the string partially.
> >
> > Does this comment belong to the 1st patch?
> > prepend_name_with_len() is not called in this patch.
> >
> Tend to remove this paragraph since the comments in do_path_unsafe
> (patch1/4)
> was clear enough.
Hi,
I noticed your suggested commit msg in another thread. Please ignore above
my words.
--
Cheers,
Justin (Jia He)
next prev parent reply other threads:[~2021-06-25 2:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 5:50 [PATCH v2 0/4] make '%pD' print the full path of file Jia He
2021-06-23 5:50 ` [PATCH v2 1/4] fs: introduce helper d_path_unsafe() Jia He
2021-06-23 9:10 ` Andy Shevchenko
2021-06-24 5:48 ` Justin He
2021-07-14 8:33 ` Justin He
2021-07-14 9:17 ` Andy Shevchenko
2021-06-28 5:13 ` Justin He
2021-06-28 9:06 ` Petr Mladek
2021-07-02 6:36 ` Justin He
2021-06-23 5:50 ` [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full path of file Jia He
2021-06-23 9:14 ` Andy Shevchenko
2021-06-24 9:01 ` Petr Mladek
2021-06-24 10:49 ` Andy Shevchenko
2021-06-25 2:29 ` Justin He
2021-06-25 2:32 ` Justin He [this message]
2021-06-23 5:50 ` [PATCH v2 3/4] lib/test_printf.c: split write-beyond-buffer check in two Jia He
2021-06-23 9:16 ` Andy Shevchenko
2021-06-23 5:50 ` [PATCH v2 4/4] lib/test_printf.c: add test cases for '%pD' Jia He
2021-06-23 9:17 ` [PATCH v2 0/4] make '%pD' print the full path of file Andy Shevchenko
[not found] ` <AM6PR08MB43763816EBF217940F5B3E15F7139@AM6PR08MB4376.eurprd08.prod.outlook.com>
2021-07-14 14:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB4376C621240CD63E215C40EEF7069@AM6PR08MB4376.eurprd08.prod.outlook.com \
--to=justin.he@arm.com \
--cc=a.darwish@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).