From: Peter Chen <peter.chen@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>, Adam Ford <aford173@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robin Gong <yibin.gong@nxp.com>
Subject: RE: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
Date: Mon, 28 Sep 2020 00:08:10 +0000 [thread overview]
Message-ID: <AM7PR04MB715780C6B4BCDCC86EF91AA68B350@AM7PR04MB7157.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200927165947.7317-5-krzk@kernel.org>
Add Robin Gong.
> Subject: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's
> interrupt line pull-up
>
> The PMIC's interrupt is level low and should be pulled up. The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
>
> Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
> Fixes: 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC
> support")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 46e76cf32b2f..7dfee715a2c4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -53,6 +53,7 @@
> pmic@4b {
> compatible = "rohm,bd71847";
> reg = <0x4b>;
> + pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> interrupt-parent = <&gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1
Peter
next prev parent reply other threads:[~2020-09-28 0:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 2/6] arm64: dts: imx8mm-beacon-som: " Krzysztof Kozlowski
2020-10-07 12:51 ` Adam Ford
2020-10-30 12:25 ` Adam Ford
2020-10-30 12:27 ` Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
2020-09-28 0:07 ` Peter Chen
2020-09-28 8:06 ` Robin Gong
2020-09-27 16:59 ` [PATCH 4/6] arm64: dts: imx8mn-var-som: " Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: " Krzysztof Kozlowski
2020-09-28 0:08 ` Peter Chen [this message]
2020-09-27 16:59 ` [PATCH 6/6] arm64: dts: imx8mn-evk: " Krzysztof Kozlowski
2020-10-30 0:26 ` [PATCH 1/6] arm64: dts: imx8mm-var-som: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR04MB715780C6B4BCDCC86EF91AA68B350@AM7PR04MB7157.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=aford173@gmail.com \
--cc=anson.huang@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).