linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 王文虎 <wenhu.wang@vivo.com>
To: Andrew Donnellan <ajd@linux.ibm.com>
Cc: wangwenhu <wenhu.pku@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Fontana <rfontana@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org, lonehugo@hotmail.com
Subject: Re:Re: [PATCH] powerpc/sysdev: fix compile errors
Date: Tue, 21 Jan 2020 14:59:09 +0800 (GMT+08:00)	[thread overview]
Message-ID: <ANcAOwAACK7otVnG7VF8E4rQ.3.1579589949706.Hmail.wenhu.wang@vivo.com> (raw)
In-Reply-To: <c5256f34-176c-2e72-b0d4-4d615b96d73a@linux.ibm.com>

发件人：Andrew Donnellan <ajd@linux.ibm.com>
发送日期：2020-01-21 14:13:07
收件人：wangwenhu <wenhu.pku@gmail.com>,Benjamin Herrenschmidt <benh@kernel.crashing.org>,Paul Mackerras <paulus@samba.org>,Michael Ellerman <mpe@ellerman.id.au>,Kate Stewart <kstewart@linuxfoundation.org>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org
抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com
主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>> From: wangwenhu <wenhu.wang@vivo.com>
>> 
>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>> fix the implicit declaration compile errors when building Cache-Sram.
>> 
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                            ^~~~~~~~~~~~~~~~
>>                            bitmap_complement
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                          ^
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>    iounmap(cache_sram->base_virt);
>>    ^~~~~~~
>>    roundup
>> cc1: all warnings being treated as errors
>> 
>> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
>
>How long has this code been broken for?

It's been broken almost 15 months since the commit below:
"commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
Author: Christophe Leroy <christophe.leroy@c-s.fr>
Date:   Tue Oct 9 13:51:41 2018 +0000

    powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."

And we are working on it now for further development.

>
>> ---
>>   arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> index f6c665dac725..29b6868eff7d 100644
>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/of_platform.h>
>>   #include <asm/pgtable.h>
>>   #include <asm/fsl_85xx_cache_sram.h>
>> +#include <asm/io.h>
>> 
>>   #include "fsl_85xx_cache_ctlr.h"
>> 
>
>-- 
>Andrew Donnellan              OzLabs, ADL Canberra
>ajd@linux.ibm.com             IBM Australia Limited
>

Wenhu


  reply	other threads:[~2020-01-21  6:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  5:31 [PATCH] powerpc/sysdev: fix compile errors wangwenhu
2020-01-21  5:58 ` Christophe Leroy
2020-01-21  6:13 ` Andrew Donnellan
2020-01-21  6:59   ` 王文虎 [this message]
2020-01-21  8:21     ` Christophe Leroy
2020-01-21  8:37     ` Christophe Leroy
2020-02-18 10:25       ` 王文虎

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ANcAOwAACK7otVnG7VF8E4rQ.3.1579589949706.Hmail.wenhu.wang@vivo.com \
    --to=wenhu.wang@vivo.com \
    --cc=ajd@linux.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lonehugo@hotmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=rfontana@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    --cc=wenhu.pku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).