From: "Michael Williams (ATG)" <Michael.Williams@arm.com>
To: Will Deacon <will@kernel.org>, Besar Wicaksono <bwicaksono@nvidia.com>
Cc: Suzuki Poulose <Suzuki.Poulose@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
Thanu Rangarajan <Thanu.Rangarajan@arm.com>,
"treding@nvidia.com" <treding@nvidia.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"vsethi@nvidia.com" <vsethi@nvidia.com>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"mike.leach@linaro.org" <mike.leach@linaro.org>,
"leo.yan@linaro.org" <leo.yan@linaro.org>
Subject: RE: [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight PMU driver
Date: Wed, 28 Sep 2022 08:31:24 +0000 [thread overview]
Message-ID: <AS2PR08MB8576965E67E5C4B31487011E8A549@AS2PR08MB8576.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20220922135257.GD12095@willie-the-truck>
Hi Will,
> -----Original Message-----
> From: Will Deacon <will@kernel.org>
> Sent: 22 September 2022 14:53
> To: Besar Wicaksono <bwicaksono@nvidia.com>
> Subject: Re: [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight
> PMU driver
[...]
> > +/* Check if PMU supports 64-bit single copy atomic. */ static inline
> > +bool supports_64bit_atomics(const struct arm_cspmu *cspmu) {
> > + return CHECK_APMT_FLAG(cspmu->apmt_node->flags, ATOMIC, SUPP); }
>
> Is this just there because the architecture permits it, or are folks
> actually hanging these things off 32-bit MMIO buses on arm64 SoCs?
The CPU PMU is often exposed on the CoreSight APB bus (32-bit), and although this driver wouldn't normally be used to access that PMU, I wouldn't rule out similar legacy APB and AHB interfaces being used for other PMUs. A further issue is that the CoreSight PMU model includes a number of 32-bit control registers.
Since issue H.a there is an alternative 64-bit native PMU interface described in the Arm ARM, which must support 64-bit atomic accesses. You might expect this to also appear in CoreSight PMU at some point soon. That would need some additional updates to this driver because all the registers are now 64 bit, which changes some offsets.
Regards,
Mike.
next prev parent reply other threads:[~2022-09-28 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 18:23 [PATCH v4 0/2] perf: ARM CoreSight PMU support Besar Wicaksono
2022-08-14 18:23 ` [PATCH v4 1/2] perf: arm_cspmu: Add support for ARM CoreSight PMU driver Besar Wicaksono
2022-09-22 13:52 ` Will Deacon
2022-09-27 3:59 ` Besar Wicaksono
2022-09-28 8:31 ` Michael Williams (ATG) [this message]
2022-09-27 11:39 ` Suzuki K Poulose
2022-09-28 1:27 ` Besar Wicaksono
2022-08-14 18:23 ` [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF and MCF attribute Besar Wicaksono
2022-09-27 11:42 ` Suzuki K Poulose
2022-09-28 1:38 ` Besar Wicaksono
2022-09-28 10:47 ` Suzuki K Poulose
2022-08-23 17:24 ` [PATCH v4 0/2] perf: ARM CoreSight PMU support Besar Wicaksono
2022-09-22 13:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS2PR08MB8576965E67E5C4B31487011E8A549@AS2PR08MB8576.eurprd08.prod.outlook.com \
--to=michael.williams@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=Thanu.Rangarajan@arm.com \
--cc=bwicaksono@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=treding@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).