From: Hongxing Zhu <hongxing.zhu@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management support
Date: Thu, 10 Feb 2022 01:58:19 +0000 [thread overview]
Message-ID: <AS8PR04MB867686E541F5065084153F8E8C2F9@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <48735d86d0685a0c94e74481ed5fdf6fe66da8be.camel@pengutronix.de>
> -----Original Message-----
> From: Lucas Stach <l.stach@pengutronix.de>
> Sent: 2022年2月9日 17:08
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com;
> lorenzo.pieralisi@arm.com; shawnguo@kernel.org
> Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management
> support
>
> s/pcie/PCIe/ and maybe s/imx6qp/i.MX6QP/ in the subject.
Thanks, would be changed later.
>
> Am Mittwoch, dem 09.02.2022 um 15:02 +0800 schrieb Richard Zhu:
> > i.MX6QP PCIe supports the RESET logic, thus it can support the L2 exit
> > by the reset mechanism.
> > Enable the i.MX6QP PCIe suspend/resume operations support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
>
> Other than the nitpick:
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Thanks.
Best Regards
Richard Zhu>
> > ---
> > drivers/pci/controller/dwc/pci-imx6.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> > b/drivers/pci/controller/dwc/pci-imx6.c
> > index 784801f2f9e6..62262483470a 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -995,6 +995,7 @@ static void imx6_pcie_pm_turnoff(struct imx6_pcie
> *imx6_pcie)
> > /* Others poke directly at IOMUXC registers */
> > switch (imx6_pcie->drvdata->variant) {
> > case IMX6SX:
> > + case IMX6QP:
> > regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > IMX6SX_GPR12_PCIE_PM_TURN_OFF,
> > IMX6SX_GPR12_PCIE_PM_TURN_OFF);
> > @@ -1307,7 +1308,8 @@ static const struct imx6_pcie_drvdata drvdata[] =
> {
> > [IMX6QP] = {
> > .variant = IMX6QP,
> > .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> > - IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE,
> > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
> > + IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
> > .dbi_length = 0x200,
> > },
> > [IMX7D] = {
>
next prev parent reply other threads:[~2022-02-10 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 7:02 [RFC 1/2] ARM: dts: imx6qp-sabresd: Enable pcie support Richard Zhu
2022-02-09 7:02 ` [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management support Richard Zhu
2022-02-09 9:07 ` Lucas Stach
2022-02-10 1:58 ` Hongxing Zhu [this message]
2022-02-09 15:36 ` Bjorn Helgaas
2022-02-10 3:23 ` Hongxing Zhu
2022-02-10 22:04 ` Bjorn Helgaas
2022-02-11 2:05 ` Hongxing Zhu
2022-02-11 16:53 ` Bjorn Helgaas
2022-02-15 3:16 ` Hongxing Zhu
2022-02-09 9:05 ` [RFC 1/2] ARM: dts: imx6qp-sabresd: Enable pcie support Lucas Stach
2022-02-10 1:49 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB867686E541F5065084153F8E8C2F9@AS8PR04MB8676.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).