From: Hongxing Zhu <hongxing.zhu@nxp.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>, Frank Li <frank.li@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains
Date: Mon, 28 Aug 2023 01:11:11 +0000 [thread overview]
Message-ID: <AS8PR04MB8676BEC9BC60872589519BCF8CE0A@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <eda5944e3d36d1daf25e5b8613f6f781d5fafc18.camel@toradex.com>
> -----Original Message-----
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Sent: 2023年8月26日 15:34
> To: s.hauer@pengutronix.de; festevam@gmail.com; Clark Wang
> <xiaoning.wang@nxp.com>; Frank Li <frank.li@nxp.com>; Hongxing Zhu
> <hongxing.zhu@nxp.com>; shawnguo@kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; kernel@pengutronix.de;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and
> SERDES0 power domains
>
> Hi Richard Zhu
>
> Thanks!
>
> How about the dc1 and gpu1 ones?
>
> On Fri, 2023-08-25 at 15:47 +0800, Richard Zhu wrote:
> > Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
>
> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
Hi Marcel:
Thanks.
I just add the HSIO SS PDs, and verified with my local HSIO support patches.
Since I can't verify the dc1 and gpu1 ones now, so I didn't add them this time.
Best Regards
Richard Zhu
> > ---
> > drivers/firmware/imx/scu-pd.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/firmware/imx/scu-pd.c
> > b/drivers/firmware/imx/scu-pd.c index 84b673427073..7b8c2689b49c
> > 100644
> > --- a/drivers/firmware/imx/scu-pd.c
> > +++ b/drivers/firmware/imx/scu-pd.c
> > @@ -165,7 +165,10 @@ static const struct imx_sc_pd_range
> > imx8qxp_scu_pd_ranges[] = {
> > { "gpu0-pid", IMX_SC_R_GPU_0_PID0, 4, true, 0 },
> >
> > /* HSIO SS */
> > + { "pcie-a", IMX_SC_R_PCIE_A, 1, false, 0 },
> > { "pcie-b", IMX_SC_R_PCIE_B, 1, false, 0 },
> > + { "sata-0", IMX_SC_R_SATA_0, 1, false, 0 },
> > + { "serdes-0", IMX_SC_R_SERDES_0, 1, false, 0 },
> > { "serdes-1", IMX_SC_R_SERDES_1, 1, false, 0 },
> > { "hsio-gpio", IMX_SC_R_HSIO_GPIO, 1, false, 0 },
>
> Cheers
>
> Marcel
next prev parent reply other threads:[~2023-08-28 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 7:47 [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains Richard Zhu
2023-08-26 7:34 ` Marcel Ziswiler
2023-08-28 1:11 ` Hongxing Zhu [this message]
2023-09-24 14:07 ` Shawn Guo
2023-09-25 0:24 ` Shawn Guo
2023-09-25 1:48 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB8676BEC9BC60872589519BCF8CE0A@AS8PR04MB8676.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).