From: Leo Li <leoyang.li@nxp.com>
To: Michael Walle <michael@walle.cc>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: RE: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc
Date: Thu, 20 Jan 2022 08:06:48 +0000 [thread overview]
Message-ID: <AS8PR04MB89460673836CDB9AEFC0C09A8F5A9@AS8PR04MB8946.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210831134013.1625527-3-michael@walle.cc>
> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Tuesday, August 31, 2021 9:40 PM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Vladimir Oltean <vladimir.oltean@nxp.com>;
> Michael Walle <michael@walle.cc>
> Subject: [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node into /soc
>
> Move it inside the /soc subnode because it is part of the CCSR space.
I just noticed that the dp0_out label has been changed to dpi0_out besides the move. Is this an intentional change or a typo? If intentional we probably should mention it, otherwise we should change it back as it is breaking build for off-tree patch that uses the label.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 41 ++++++++++---------
> 1 file changed, 21 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 9a65a7118faa..92e4f004c1c2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -793,6 +793,27 @@ QORIQ_CLK_PLL_DIV(16)>,
> clock-names = "wdog_clk", "apb_pclk";
> };
>
> + malidp0: display@f080000 {
> + compatible = "arm,mali-dp500";
> + reg = <0x0 0xf080000 0x0 0x10000>;
> + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> + <0 223 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "DE", "SE";
> + clocks = <&dpclk>,
> + <&clockgen QORIQ_CLK_HWACCEL 2>,
> + <&clockgen QORIQ_CLK_HWACCEL 2>,
> + <&clockgen QORIQ_CLK_HWACCEL 2>;
> + clock-names = "pxlclk", "mclk", "aclk", "pclk";
> + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> + arm,malidp-arqos-value = <0xd000d000>;
> +
> + port {
> + dpi0_out: endpoint {
> +
> + };
> + };
> + };
> +
> sai1: audio-controller@f100000 {
> #sound-dai-cells = <0>;
> compatible = "fsl,vf610-sai";
> @@ -1139,24 +1160,4 @@ ftm_alarm0: timer@2800000 {
> };
> };
>
> - malidp0: display@f080000 {
> - compatible = "arm,mali-dp500";
> - reg = <0x0 0xf080000 0x0 0x10000>;
> - interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> - <0 223 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "DE", "SE";
> - clocks = <&dpclk>,
> - <&clockgen QORIQ_CLK_HWACCEL 2>,
> - <&clockgen QORIQ_CLK_HWACCEL 2>,
> - <&clockgen QORIQ_CLK_HWACCEL 2>;
> - clock-names = "pxlclk", "mclk", "aclk", "pclk";
> - arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> - arm,malidp-arqos-value = <0xd000d000>;
> -
> - port {
> - dp0_out: endpoint {
> -
> - };
> - };
> - };
> };
> --
> 2.30.2
next prev parent reply other threads:[~2022-01-20 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 13:40 [PATCH 0/7] arm64: dts: ls1028: GPU support and cleanups Michael Walle
2021-08-31 13:40 ` [PATCH 1/7] arm64: dts: ls1028a: move pixel clock pll into /soc Michael Walle
2021-08-31 13:40 ` [PATCH 2/7] arm64: dts: ls1028a: move Mali DP500 node " Michael Walle
2022-01-20 8:06 ` Leo Li [this message]
2022-01-20 8:17 ` Michael Walle
2021-08-31 13:40 ` [PATCH 3/7] arm64: dts: ls1028a: add Vivante GPU node Michael Walle
2021-08-31 13:40 ` [PATCH 4/7] arm64: dts: freescale: fix arm,sp805 compatible string Michael Walle
2021-08-31 13:40 ` [PATCH 5/7] arm64: dts: ls1028a: disable usb controller by default Michael Walle
2021-08-31 14:08 ` Vladimir Oltean
2021-08-31 13:40 ` [PATCH 6/7] arm64: dts: ls1028a: move PHY nodes to MDIO controller Michael Walle
2021-08-31 14:07 ` Vladimir Oltean
2021-08-31 13:40 ` [PATCH 7/7] arm64: dts: ls1028a: use phy-mode instead of phy-connection-type Michael Walle
2021-08-31 13:59 ` Vladimir Oltean
2021-08-31 14:06 ` Michael Walle
2021-10-04 13:02 ` [PATCH 0/7] arm64: dts: ls1028: GPU support and cleanups Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB89460673836CDB9AEFC0C09A8F5A9@AS8PR04MB8946.eurprd04.prod.outlook.com \
--to=leoyang.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).