From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AB4C433E0 for ; Thu, 18 Feb 2021 18:49:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54DE164EB8 for ; Thu, 18 Feb 2021 18:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbhBRSsi (ORCPT ); Thu, 18 Feb 2021 13:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233590AbhBRQiV (ORCPT ); Thu, 18 Feb 2021 11:38:21 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7132C06178A; Thu, 18 Feb 2021 08:36:28 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id g20so1551003plo.2; Thu, 18 Feb 2021 08:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9YZ7rIwkTg0cr9K1NBvxWl16zBakNNAe5KH+Me4Ez0g=; b=ocXxDQi9CRB9L5lngEyoeBmXLFzDCcvpy+RjN+HSy7/ENmfhYoZEp9DUa+Yc2CCc4t BFG3A1G0DyXzhFb+h5JjXRcqME8r5J3YPFAITW2WA46/i+j0T5roVTyLMv6+rRR80Pk6 n/eNqzFcL1FLC5ruKnx0rUaOu9nABMBOwMqGtC+tSiCDibReTxaPJz809RViZkwG1VQ9 yAScaSxi4YFA+TsUdxbHYYw49U0YvcRAAukBTTvgYyax6UlD0zT3HXeGOJLLRy6qj1rG ZxBuUC8boazXwDk0HKu6ewI9hDzc+C0rTZHEfloHhraXhObPOw5NvmUK823UvwT0cr4F o8QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9YZ7rIwkTg0cr9K1NBvxWl16zBakNNAe5KH+Me4Ez0g=; b=NtKjardkPzG+p90+PcY21gRpeTFVxMCbjrhyCGVXHDL5N0nbwxy3IfLR2Azq4rZXvh oLCKq/433YEkUnjxaS2x3RqCLCxwFdshu3XDTp3MpQk1pZyaJO7uanH8U4+Ym4cFc74n KfoZ+fkrsD8fmpG09BdUQrLlxD6/wZ6G8EcFKMOpFgWTlKRwAKZQ4SXhqd7mz8FsKAuj tRAmlCXkQUeDVZTWNOQ1z9z8vERsgN7hX59Xg1LPnw4eLYdedODG9gN9HZ3no864BXN4 0sstArcuajyzwzGbvZZVpBpV5qj3humo5MhkHjqMGuWh7oxDuRsYlvSsJ4YH8mbCa47K Cfqw== X-Gm-Message-State: AOAM533kDDqZ6o2hLSKiiwhRPMHhMtTntQldiYe55ZSVrWcjCfme95s6 WXn1lFrwKG3MiLuJTF6pG0w= X-Google-Smtp-Source: ABdhPJy8m6ISygrI5oodlvagJHQ0wLuOh7fOT75dZQuJUpy4FiSWhDdPY08jJ17G7oH72p25FXrNaA== X-Received: by 2002:a17:90a:62c1:: with SMTP id k1mr4657174pjs.79.1613666188300; Thu, 18 Feb 2021 08:36:28 -0800 (PST) Received: from [172.20.192.5] ([122.10.101.134]) by smtp.gmail.com with ESMTPSA id a5sm6442110pgl.41.2021.02.18.08.36.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 08:36:21 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH From: =?utf-8?B?6buE5a2m5qOu?= In-Reply-To: <29b5395f-daff-99f2-4a4b-6d462623a9fe@iogearbox.net> Date: Fri, 19 Feb 2021 00:35:44 +0800 Cc: Willem de Bruijn , David Miller , bpf , Network Development , LKML , Willem de Bruijn , chengzhiyong , wangli , Alan Maguire Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210210065925.22614-1-hxseverything@gmail.com> <29b5395f-daff-99f2-4a4b-6d462623a9fe@iogearbox.net> To: Daniel Borkmann X-Mailer: Apple Mail (2.3608.120.23.2.1) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Daniel and Willem! So sorry to reply to you late for I just took the Chinese Spring = Festival vacation. I will resubmit this patch. Thanks again! > 2021=E5=B9=B42=E6=9C=8811=E6=97=A5 =E4=B8=8B=E5=8D=8811:26=EF=BC=8CDanie= l Borkmann =E5=86=99=E9=81=93=EF=BC=9A >=20 > On 2/10/21 3:50 PM, Willem de Bruijn wrote: >> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen = wrote: >>>=20 >>> From: huangxuesen >>>=20 >>> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for = packets >>> encapsulation. But that is not appropriate when pushing Ethernet = header. >>>=20 >>> Add an option to further specify encap L2 type and set the = inner_protocol >>> as ETH_P_TEB. >>>=20 >>> Suggested-by: Willem de Bruijn >>> Signed-off-by: huangxuesen >>> Signed-off-by: chengzhiyong >>> Signed-off-by: wangli >> Thanks, this is exactly what I meant. >> Acked-by: Willem de Bruijn >> One small point regarding Signed-off-by: It is customary to = capitalize >> family and given names. >=20 > +1, huangxuesen, would be great if you could resubmit with capitalized = names in > your SoB as well as =46rom (both seem affected). >=20 > Thanks, > Daniel