From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751363AbdAUNR7 (ORCPT ); Sat, 21 Jan 2017 08:17:59 -0500 Received: from mo4-p04-ob.smtp.rzone.de ([81.169.146.177]:23371 "EHLO mo4-p04-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbdAUNR5 (ORCPT ); Sat, 21 Jan 2017 08:17:57 -0500 X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID83POEjEaE= Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) From: "H. Nikolaus Schaller" In-Reply-To: <17d2c23b-6cbb-d365-71cb-fd4d7af7c958@kernel.org> Date: Sat, 21 Jan 2017 14:17:39 +0100 Cc: Sebastian Reichel , Mark Rutland , =?windows-1252?Q?Beno=EEt_Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Michael Welling , =?windows-1252?Q?Mika_Penttil=E4?= , Javier Martinez Canillas , Igor Grinberg , "Andrew F. Davis" , Mark Brown , Rob Herring , Alexander Stein , Eric Engestrom , Hans de Goede , Benjamin Tissoires , Petr Cvek , Mauro Carvalho Chehab , Hans Verkuil , Nick Dyer , Siebren Vroegindeweij , Michel Verlaan , linux-input@vger.kernel.org, devicetree , LKML , linux-omap , Discussions about the Letux Kernel , linux-iio@vger.kernel.org, kernel@pyra-handheld.com Message-Id: References: <17d2c23b-6cbb-d365-71cb-fd4d7af7c958@kernel.org> To: Jonathan Cameron , Dmitry Torokhov X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0LDI9TJ022181 > Am 21.01.2017 um 14:08 schrieb Jonathan Cameron : > > On 16/01/17 06:34, H. Nikolaus Schaller wrote: >> ping > Always good to say who you are pinging ;) default = Maintainer Only he/she can finally accept a patch series so I assume he has to take action if there are no more things to debate. > Saves the rest of us wondering > if we have missing something we should have reviewed. > > Guessing it's Dmitry in this case! Yes, you are right. Since there have not been any more comments for a while, I formally ask to add this to some tree so that it appears in linux-next for further tests. BR and thanks, Nikolaus > > Jonathan >> >>> Am 28.12.2016 um 15:53 schrieb H. Nikolaus Schaller : >>> >>> Changes V9: >>> * added explicit CONFIG for TSC2007_IIO and simplified Makefile (suggested by Dmitry Torokhov ) >>> * make the tsc2007 iio patch the last one in this sequence >>> >>> 2016-11-22 15:02:42: Changes V8: >>> * fix compilation for CONFIG_IIO=m (reported by Jonathan Cameron ) >>> * add some more Reviewed-by: and Acked-by: >>> * mutiple improvements suggested by Dmitry Torokhov : >>> ** drop patch "send pendown and penup only once" (input core does take care of it now) >>> ** remove not necessary EXPORT_SYMBOL >>> ** remove explicit file names from comment header >>> ** move tsc2007_iio_configure() to the end of the probe process and simplify the error path again >>> ** remove unnecessary input_unregister_device() >>> ** improvement for compilation with CONFIG_IIO=m and CONFIG_TSC2007=y >>> >>> 2016-11-11 20:02:11: Changes V7: >>> * rearranged the include files (asked for by Jonathan Cameron ) >>> * forward reference struct iio_dev * instead of condition in tsc2007.h (asked for by Jonathan Cameron ) >>> * add some Acked-by: >>> >>> 2016-10-27 10:44:29: Changes V6: >>> * iio patch (no changes elsewhere) >>> - tsc2007_iio: fix a missing return 0 for non-iio case (found by kbuid test robot) >>> - tsc2007_core: group error return paths so that tsc2007_iio_unconfigure is called at only one place >>> - tsc2007_iio: fix copyright (this file is 100% original work) >>> >>> 2016-10-25 21:26:46: Changes V5: >>> * ads7846: remove an empty line (suggested by Andrew F. Davis ) >>> * ads7846: remove MODULE_ALIAS for SPI (suggested by Andrew F. Davis ) >>> * tsc2007: fix a bug from swapping patch 3/n and patch 4/n (found by kbuild test robot) >>> * refactored tsc2007 into tsc2007_core and tsc2007_iio (asked for by Jonathan Cameron ) >>> >>> 2016-10-17 16:00:02: Changes V4: >>> * fix a merge/squash issue resulting in a non-bisectable patch set (suggested by kbuid test robot) >>> * remove some unnecessary #include (suggested by Jonathan Cameron ) >>> * make the iio extension depend on CONFIG_IIO rather than selecting it (suggested by Jonathan Cameron ) >>> * swapped patch 3/n and patch 4/n to remove internal dependency >>> >>> 2016-09-23 14:41:23: Changes V3: >>> * fix an issue with swapping >>> * remove hard clipping to min/max rectangle - some systems expect to handle negative coordinates >>> * make use of commit ed7c9870c9bc ("Input: of_touchscreen - add support for inverted / swapped axes") >>> >>> 2015-11-13 21:36:07: Changes V2: >>> * add a patch to make drivers still recognise the old "ti,swap-xy" property (suggested by Rob Herring) >>> >>> 2015-11-06 16:14:53: V1: This patch series improves the drivers for the tsc2007 and >>> ads7846/tsc2046 touchscreen controllers which are e.g. used by the GTA04 >>> OpenPandora and Pyra devices. >>> >>> New common bindings have been defined by >>> commit b98abe52fa8e ("Input: add common DT binding for touchscreens"): >>> >>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >>> >>> which also defines a helper function to parse the DT. These new parameters >>> allow to specify the fuzz factors (jitter suppression), inversion of x or y axis and >>> swapping of x and y to achieve inversion and rotation so that the touch >>> coordinate axes match the natural orientation of the display panel. >>> >>> Another improvement is to better use the min/max ADC values and >>> scale to the screen size as defined by the DT. This allows to coarsely >>> calibrate the touch to match the LCD to which it is glued on so that the >>> touch can quite precisely be operated before any user-space fine-calibration >>> can be (and needs to be) started. >>> >>> For the adc7846 we fix an issue with the spi module table. >>> >>> Finally we add an iio interface for the AUX and temperature ADC channels of >>> the tsc2007 and also provide the touch screen raw values. This allows to read >>> an optional ambient light sensor installed on the gta04 board and improves >>> calibration and hardware monitoring. >>> >>> >>> H. Nikolaus Schaller (8): >>> drivers:input:tsc2007: add new common binding names, pre-calibration, >>> flipping and rotation >>> drivers:input:tsc2007: check for presence and power down tsc2007 >>> during probe >>> DT:omap3+tsc2007: use new common touchscreen bindings >>> drivers:input:ads7846(+tsc2046): add new common binding names, >>> pre-calibration and flipping >>> dt-bindings: input: move ads7846 bindings to touchscreen subdirectory >>> drivers:input:ads7846(+tsc2046): fix spi module table >>> DT:omap3+ads7846: use new common touchscreen bindings >>> drivers:input:tsc2007: add iio interface to read external ADC input >>> and temperature >>> >>> .../bindings/input/{ => touchscreen}/ads7846.txt | 9 +- >>> .../bindings/input/touchscreen/tsc2007.txt | 20 +- >>> arch/arm/boot/dts/omap3-gta04.dtsi | 25 ++- >>> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 2 +- >>> arch/arm/boot/dts/omap3-pandora-common.dtsi | 17 +- >>> .../boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 3 +- >>> drivers/input/touchscreen/Kconfig | 10 + >>> drivers/input/touchscreen/Makefile | 2 + >>> drivers/input/touchscreen/ads7846.c | 71 ++++++-- >>> drivers/input/touchscreen/tsc2007.h | 116 ++++++++++++ >>> .../touchscreen/{tsc2007.c => tsc2007_core.c} | 201 ++++++++++++--------- >>> drivers/input/touchscreen/tsc2007_iio.c | 150 +++++++++++++++ >>> include/linux/i2c/tsc2007.h | 8 + >>> 13 files changed, 520 insertions(+), 114 deletions(-) >>> rename Documentation/devicetree/bindings/input/{ => touchscreen}/ads7846.txt (90%) >>> create mode 100644 drivers/input/touchscreen/tsc2007.h >>> rename drivers/input/touchscreen/{tsc2007.c => tsc2007_core.c} (74%) >>> create mode 100644 drivers/input/touchscreen/tsc2007_iio.c >>> >>> -- >>> 2.7.3 >>> >> >