From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755395AbcFQNoc (ORCPT ); Fri, 17 Jun 2016 09:44:32 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:55304 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbcFQNoa (ORCPT ); Fri, 17 Jun 2016 09:44:30 -0400 From: "Yang, Wenyou" To: Alexandre Belloni , Rob Herring CC: Alan Stern , Greg Kroah-Hartman , "Ferre, Nicolas" , Pawel Moll , Mark Brown , "Ian Campbell" , Kumar Gala , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Topic: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Index: AQHRwT2xWYbSq6bIWUSmWyTi3K9vCp/ff5WAgAADKgCADja6wA== Date: Fri, 17 Jun 2016 13:44:22 +0000 Message-ID: References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <20160608202651.GA23604@rob-hp-laptop> <20160608203810.GF2466@piout.net> In-Reply-To: <20160608203810.GF2466@piout.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5HDiacI009996 Hi Alexandre, > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 2016Äê6ÔÂ9ÈÕ 4:38 > To: Rob Herring > Cc: Yang, Wenyou ; Alan Stern > ; Greg Kroah-Hartman > ; Ferre, Nicolas ; > Pawel Moll ; Mark Brown ; Ian > Campbell ; Kumar Gala ; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB > suspend > > On 08/06/2016 at 15:26:51 -0500, Rob Herring wrote : > > On Wed, Jun 08, 2016 at 12:15:10PM +0800, Wenyou Yang wrote: > > > In order to the save power consumption, as a workaround, suspend > > > forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI > > > Interrupt Configuration Register in the SFRs while OHCI USB suspend. > > > > > > This suspend operation must be done before the USB clock is > > > disabled, resume after the USB clock is enabled. > > > > > > Signed-off-by: Wenyou Yang > > > --- > > > > > > Changes in v3: > > > - Change the compatible description for more precise. > > > > > > Changes in v2: > > > - Add compatible to support forcibly suspend the ports. > > > - Add soc/at91/at91_sfr.h to accommodate the defines. > > > - Add error checking for .sfr_regmap. > > > - Remove unnecessary regmap_read() statement. > > > > > > .../devicetree/bindings/usb/atmel-usb.txt | 6 +- > > > drivers/usb/host/ohci-at91.c | 80 +++++++++++++++++++++- > > > include/soc/at91/at91_sfr.h | 29 ++++++++ > > > 3 files changed, 112 insertions(+), 3 deletions(-) create mode > > > 100644 include/soc/at91/at91_sfr.h > > > > > > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt > > > b/Documentation/devicetree/bindings/usb/atmel-usb.txt > > > index 5883b73..888deaa 100644 > > > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt > > > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt > > > @@ -3,8 +3,10 @@ Atmel SOC USB controllers OHCI > > > > > > Required properties: > > > - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers > > > - used in host mode. > > > + - compatible: Should be one of the following > > > + "atmel,at91rm9200-ohci" for USB controllers used in host mode. > > > + "atmel,sama5d2-ohci" for USB controllers used in host mode > > > + on SAMA5D2 which can force to suspend. > > > > Guess I wasn't clear enough before. Drop "which can force to suspend". > > > > Well, my point is that we don't need a new compatible anyway. Could you give some advice?. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang