From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbcFTHuP (ORCPT ); Mon, 20 Jun 2016 03:50:15 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:18729 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbcFTHty (ORCPT ); Mon, 20 Jun 2016 03:49:54 -0400 From: "Yang, Wenyou" To: "Ferre, Nicolas" , Alan Stern , Greg Kroah-Hartman , Rob Herring , Alexandre Belloni CC: Pawel Moll , Mark Brown , "Ian Campbell" , Kumar Gala , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Topic: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Index: AQHRwT2xWYbSq6bIWUSmWyTi3K9vCp/e0bsAgAALeICAEy9rsA== Date: Mon, 20 Jun 2016 07:49:24 +0000 Message-ID: References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <5757EDB4.3020806@atmel.com> <5757F753.8010408@atmel.com> In-Reply-To: <5757F753.8010408@atmel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5K7oPPE022003 > -----Original Message----- > From: Ferre, Nicolas > Sent: 2016Äê6ÔÂ8ÈÕ 18:46 > To: Yang, Wenyou ; Alan Stern > ; Greg Kroah-Hartman > ; Rob Herring ; Alexandre > Belloni > Cc: Pawel Moll ; Mark Brown ; Ian > Campbell ; Kumar Gala ; > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB > suspend > > Le 08/06/2016 12:04, Nicolas Ferre a ¨¦crit : > > Le 08/06/2016 06:15, Wenyou Yang a ¨¦crit : > >> In order to the save power consumption, as a workaround, suspend > >> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI > >> Interrupt Configuration Register in the SFRs while OHCI USB suspend. > >> > >> This suspend operation must be done before the USB clock is disabled, > >> resume after the USB clock is enabled. > >> > >> Signed-off-by: Wenyou Yang > > > > Little nitpicking below... > > > >> --- > >> > >> Changes in v3: > >> - Change the compatible description for more precise. > >> > >> Changes in v2: > >> - Add compatible to support forcibly suspend the ports. > >> - Add soc/at91/at91_sfr.h to accommodate the defines. > >> - Add error checking for .sfr_regmap. > >> - Remove unnecessary regmap_read() statement. > >> > >> .../devicetree/bindings/usb/atmel-usb.txt | 6 +- > >> drivers/usb/host/ohci-at91.c | 80 +++++++++++++++++++++- > >> include/soc/at91/at91_sfr.h | 29 ++++++++ > > Oops sorry, additional comment which is not nitpicking, this one: > > We already have SFR header file in this patch: > > Author: Cyrille Pitchen > Date: Thu Mar 17 17:04:00 2016 +0100 > > ARM: dts: at91: sama5d2: add SFR node > > This SFR node is looked up by the I2S controller driver to tune the > SFR_I2SCLKSEL register. > > Signed-off-by: Cyrille Pitchen > Signed-off-by: Ludovic Desroches > Acked-by: Alexandre Belloni > Acked-by: Rob Herring > Signed-off-by: Nicolas Ferre > > Which is already accepted by arm-soc guys for 4.7... So my ack transforms into a > nack, sorry... > > We will have to coordinate the effort and maybe take the whole series with us. But > for sure, you'll have to use the existing include/soc/at91/atmel-sfr.h file and build > on top of it... Sorry, not notice this file. I will built it on this file. > > Bye, > > >> 3 files changed, 112 insertions(+), 3 deletions(-) create mode > >> 100644 include/soc/at91/at91_sfr.h > > [..] > > > > > But you can take my: > > > > Acked-by: Nicolas Ferre > > > > with the little corrections listed. > > > > Alan, We plan to take the second patch of this series with AT91 git > > tree through arm-soc. Do you agree to take this one through yours? > > Alan, forget this request, we'll have to coordinate differently. > > Sorry for the noise. Bye, > -- > Nicolas Ferre Best Regards, Wenyou Yang