From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538AbcFTIuQ (ORCPT ); Mon, 20 Jun 2016 04:50:16 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:28946 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbcFTIth (ORCPT ); Mon, 20 Jun 2016 04:49:37 -0400 From: "Yang, Wenyou" To: Alexandre Belloni CC: Rob Herring , Alan Stern , Greg Kroah-Hartman , "Ferre, Nicolas" , Pawel Moll , Mark Brown , Ian Campbell , "Kumar Gala" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Topic: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Thread-Index: AQHRwT2xWYbSq6bIWUSmWyTi3K9vCp/ff5WAgAADKgCADja6wP//fY4AgASJ6jD//8rzAIAAiVuQ Date: Mon, 20 Jun 2016 08:46:02 +0000 Message-ID: References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <20160608202651.GA23604@rob-hp-laptop> <20160608203810.GF2466@piout.net> <20160617135448.GI5809@piout.net> <20160620080334.GL5809@piout.net> In-Reply-To: <20160620080334.GL5809@piout.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5K8oUas022371 Hi Alexandre & Nicolas, > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 2016Äê6ÔÂ20ÈÕ 16:04 > To: Yang, Wenyou > Cc: Rob Herring ; Alan Stern ; > Greg Kroah-Hartman ; Ferre, Nicolas > ; Pawel Moll ; Mark Brown > ; Ian Campbell ; Kumar > Gala ; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > usb@vger.kernel.org > Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB > suspend > > On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote : > > > Sure, what I mean is that you can try to get the regmap for the SFR in every > case. > > > Depending on whether you were able to get it, you can decide to call > > > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL). > > > > I don't think so. The SFR includes a lot of miscellaneous functions, more than > this one. > > > > I know but this is irrelevant to this discussion. If you need to use the SFR from > another driver you will simply get it from that other driver. > > I that case, you will try to get "atmel,sama5d2-sfr". It is only present on sama5d2 > so you have enough information to know whether or not you can use it to > suspend/resume. I understand what your meaning :). Use "atmel,sama5d2-sfr" compatible to distinguish whether forcibly suspend USB port via SFR or not. I am not sure if it is a better solution. Nicolas, could you give your opinion? > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang