From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366Ab2LFAzb (ORCPT ); Wed, 5 Dec 2012 19:55:31 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:2982 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501Ab2LFAz3 (ORCPT ); Wed, 5 Dec 2012 19:55:29 -0500 From: "Yang, Wenyou" To: Florian Fainelli CC: "linux-arm-kernel@lists.infradead.org" , "Ferre, Nicolas" , "plagnioj@jcrosoft.com" , "Lin, JM" , "wim@iguana.be" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework Thread-Topic: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework Thread-Index: AQHN0olaD9JBif6wV0q1X7tzAJygsJgJgLSAgAFyEGA= Date: Thu, 6 Dec 2012 00:54:48 +0000 Message-ID: References: <1354671267-19277-1-git-send-email-wenyou.yang@atmel.com> <1354671267-19277-3-git-send-email-wenyou.yang@atmel.com> <3976223.KImVV2lC5B@flexo> In-Reply-To: <3976223.KImVV2lC5B@flexo> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id qB60tYOV017317 Hi Florian, > -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] On Behalf Of Florian Fainelli > Sent: 2012年12月5日 18:48 > To: Yang, Wenyou > Cc: linux-arm-kernel@lists.infradead.org; Ferre, Nicolas; plagnioj@jcrosoft.com; Lin, > JM; wim@iguana.be; linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog > framework > > Hello Wenyou, > > On Wednesday 05 December 2012 09:34:21 Wenyou Yang wrote: > > According to the kernel document: convert_drivers_to_kernel_api.txt, > > remove the file_operations struct, miscdevice, and obsolete includes > > > > Since the at91sam watchdog inherent characteristics, add the watchdog > > operations: at91wdt_start, at91wdt_stop and at91wdt_ping. > > > > [snip] > > > > > +static inline bool watchdog_is_open(struct watchdog_device *wddev) > > +{ > > + return test_bit(WDOG_DEV_OPEN, &wddev->status); > > +} > > This helper should be moved to include/linux/watchdog.h as it can be useful > for other watchdog drivers as well. Thanks, I will move it in next version. > -- > Florian Best Regards Wenyou Yang {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I