From: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] spi/atmel: add support for runtime PM
Date: Thu, 16 Oct 2014 08:09:49 +0000 [thread overview]
Message-ID: <B256D81BAE5131468A838E5D7A243641BF589DDC@penmbx02.corp.atmel.com> (raw)
In-Reply-To: <20141016073004.GL27755@sirena.org.uk>
Hi Mark,
> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Thursday, October 16, 2014 3:30 PM
> To: Yang, Wenyou
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Ferre, Nicolas; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] spi/atmel: add support for runtime PM
>
> On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote:
>
> > +static int atmel_spi_runtime_resume(struct device *dev) {
> > + struct spi_master *master = dev_get_drvdata(dev);
> > + struct atmel_spi *as = spi_master_get_devdata(master);
> > +
> > + pinctrl_pm_select_default_state(dev);
> > + clk_prepare_enable(as->clk);
> > +
>
> This looks mostly good but you should check the return value of
> clk_prepare_enable() - it can fail.
Thanks a lot, I will add it.
Best Regards,
Wenyou Yang
next prev parent reply other threads:[~2014-10-16 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 1:49 [PATCH] spi/atmel: add support for runtime PM Wenyou Yang
2014-10-16 7:30 ` Mark Brown
2014-10-16 8:09 ` Yang, Wenyou [this message]
2014-10-17 13:02 ` Kevin Hilman
2014-10-17 13:57 ` Mark Brown
2014-10-17 14:22 ` Kevin Hilman
2014-10-17 14:31 ` Mark Brown
2014-10-20 2:05 ` Yang, Wenyou
2014-10-20 18:09 ` Kevin Hilman
2014-10-21 0:51 ` Yang, Wenyou
2014-10-20 1:59 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B256D81BAE5131468A838E5D7A243641BF589DDC@penmbx02.corp.atmel.com \
--to=wenyou.yang@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).