From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdJVMce convert rfc822-to-8bit (ORCPT ); Sun, 22 Oct 2017 08:32:34 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:14218 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbdJVMcd (ORCPT ); Sun, 22 Oct 2017 08:32:33 -0400 From: "Liuwenliang (Lamb)" To: Russell King - ARM Linux , Florian Fainelli CC: "aryabinin@virtuozzo.com" , "afzal.mohd.ma@gmail.com" , "labbott@redhat.com" , "kirill.shutemov@linux.intel.com" , "mhocko@suse.com" , "cdall@linaro.org" , "marc.zyngier@arm.com" , "catalin.marinas@arm.com" , "akpm@linux-foundation.org" , "mawilcox@microsoft.com" , "tglx@linutronix.de" , "thgarnie@google.com" , "keescook@chromium.org" , "arnd@arndb.de" , "vladimir.murzin@arm.com" , "tixy@linaro.org" , "ard.biesheuvel@linaro.org" , "robin.murphy@arm.com" , "mingo@kernel.org" , "grygorii.strashko@linaro.org" , "opendmb@gmail.com" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , Zengweilin , "linux-mm@kvack.org" , Dailei , "glider@google.com" , "dvyukov@google.com" , Jiazhenghua , "linux-arm-kernel@lists.infradead.org" , Heshaoliang Subject: Re: [PATCH 03/11] arm: Kconfig: enable KASan Thread-Topic: [PATCH 03/11] arm: Kconfig: enable KASan Thread-Index: AQHTQmojmMtNIfz8uUG4mtzXJZdPVKLef7sAgAwip4CABTkXEA== Date: Sun, 22 Oct 2017 12:27:57 +0000 Message-ID: References: <20171011082227.20546-1-liuwenliang@huawei.com> <20171011082227.20546-4-liuwenliang@huawei.com> <20171019123453.GV20805@n2100.armlinux.org.uk> In-Reply-To: <20171019123453.GV20805@n2100.armlinux.org.uk> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.57.90.243] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.59EC8ED6.0073,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.12.139, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: df0f90668bc2a18a73fa0d851cc1e4e6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2017 01:22 AM, Russell King - ARM Linux wrote: >On Wed, Oct 11, 2017 at 12:15:44PM -0700, Florian Fainelli wrote: >> On 10/11/2017 01:22 AM, Abbott Liu wrote: >> > From: Andrey Ryabinin >> > >> > This patch enable kernel address sanitizer for arm. >> > >> > Cc: Andrey Ryabinin >> > Signed-off-by: Abbott Liu >> >> This needs to be the last patch in the series, otherwise you allow >> people between patch 3 and 11 to have varying degrees of experience with >> this patch series depending on their system type (LPAE or not, etc.) > >As the series stands, if patches 1-3 are applied, and KASAN is enabled, >there are various constants that end up being undefined, and the kernel >build will fail. That is, of course, not acceptable. > >KASAN must not be available until support for it is functionally >complete. Thanks for Florian Fainelli and Russell King's review. I'm going to change it in the new version.