From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbdK0BZk convert rfc822-to-8bit (ORCPT ); Sun, 26 Nov 2017 20:25:40 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:14779 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbdK0BZj (ORCPT ); Sun, 26 Nov 2017 20:25:39 -0500 From: "Liuwenliang (Abbott Liu)" To: Russell King - ARM Linux CC: Marc Zyngier , Mark Rutland , "tixy@linaro.org" , "mhocko@suse.com" , "grygorii.strashko@linaro.org" , "catalin.marinas@arm.com" , "linux-mm@kvack.org" , "glider@google.com" , "afzal.mohd.ma@gmail.com" , "mingo@kernel.org" , Christoffer Dall , "opendmb@gmail.com" , "mawilcox@microsoft.com" , "kasan-dev@googlegroups.com" , Dailei , "dvyukov@google.com" , "aryabinin@virtuozzo.com" , "labbott@redhat.com" , "vladimir.murzin@arm.com" , "keescook@chromium.org" , "arnd@arndb.de" , Zengweilin , "f.fainelli@gmail.com" , Heshaoliang , "tglx@linutronix.de" , "linux-arm-kernel@lists.infradead.org" , "ard.biesheuvel@linaro.org" , "linux-kernel@vger.kernel.org" , Jiazhenghua , "akpm@linux-foundation.org" , "robin.murphy@arm.com" , "thgarnie@google.com" , "kirill.shutemov@linux.intel.com" Subject: Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory Thread-Topic: [PATCH 01/11] Initialize the mapping of KASan shadow memory Thread-Index: AQHTY5FZRgwPxy9r6kqLVsGKXnTkPKMf2B8AgAFa0pCAAF2CAIAF4zDw Date: Mon, 27 Nov 2017 01:23:50 +0000 Message-ID: References: <87375eqobb.fsf@on-the-bus.cambridge.arm.com> <20171117073556.GB28855@cbox> <20171118134841.3f6c9183@why.wild-wind.fr.eu.org> <20171121122938.sydii3i36jbzi7x4@lakrids.cambridge.arm.com> <757534e5-fcea-3eb4-3c8d-b8c7e709f555@arm.com> <20171123152218.GQ31757@n2100.armlinux.org.uk> In-Reply-To: <20171123152218.GQ31757@n2100.armlinux.org.uk> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.57.90.243] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.5A1B6936.001E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.11.218, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 902178c3f21c86561dbedc3fb2c69c2e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 23, 2017 23:22 Russell King - ARM Linux [mailto:linux@armlinux.org.uk] wrote: >Please pay attention to the project coding style whenever creating code >for a program. It doesn't matter what the project coding style is, as >long as you write your code to match the style that is already there. > >For the kernel, that is: tabs not spaces for indentation of code. >You seem to be using a variable number of spaces for all the new code >above. > >Some of it seems to be your email client thinking it knows better about >white space - and such behaviours basically makes patches unapplyable. >See Documentation/process/email-clients.rst for hints about email >clients. Thanks for your review. I'm going to change it in the new version.