From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: "liwei (CM)" <liwei213@huawei.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>
Cc: fengbaopeng <fengbaopeng2@hisilicon.com>,
"nsaenzjulienne@suse.de" <nsaenzjulienne@suse.de>,
"steve.capper@arm.com" <steve.capper@arm.com>,
"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
sujunfei <sujunfei2@hisilicon.com>,
"Xiaqing (A)" <saberlily.xia@hisilicon.com>,
"Yaobaofeng (Yaobaofeng)" <yaobaofeng@huawei.com>
Subject: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP
Date: Thu, 9 Jul 2020 12:27:11 +0000 [thread overview]
Message-ID: <B926444035E5E2439431908E3842AFD256289A@DGGEMI525-MBS.china.huawei.com> (raw)
In-Reply-To: <1699CE87DE933F49876AD744B5DC140F230F8396@DGGEMM506-MBS.china.huawei.com>
> -----Original Message-----
> From: liwei (CM)
> Sent: Wednesday, July 8, 2020 7:52 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>;
> catalin.marinas@arm.com; will@kernel.org
> Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> steve.capper@arm.com; rppt@linux.ibm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei
> <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>;
> Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com>
> Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory
> model that define VMEMMAP
>
> Hi, baohua
>
> Thank you for your attention.
>
> In my understanding of the MEMORY_HOTPLUG this patch has no effect on it.
> The reason is that in sparse_add_one_section() the memory that memmap
> needs from Slab if kernel start completed,this memory has nothing to do with
> memblock alloc/ free memory in the process of kernel start.
>
> You may have a look vmemmap_alloc_block () this function.
>
> If I don't understand right welcome pointed out in a timely manner.
At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory.
If you confirm this won't happen, please ignore my noise.
BTW, next time, bear in mind that top-post is not a good way to reply mail :-)
>
> Thanks!
>
>
> -----邮件原件-----
> 发件人: Song Bao Hua (Barry Song)
> 发送时间: 2020年7月8日 15:19
> 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com;
> will@kernel.org
> 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> steve.capper@arm.com; rppt@linux.ibm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei
> <sujunfei2@hisilicon.com>
> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory
> model that define VMEMMAP
>
>
>
> > -----Original Message-----
> > From: liwei (CM)
> > Sent: Wednesday, July 8, 2020 1:56 PM
> > To: catalin.marinas@arm.com; will@kernel.org
> > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng
> > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song)
> > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory
> model
> > that define VMEMMAP
> >
> > For the memory hole, sparse memory model that define
> SPARSEMEM_VMEMMAP
> > do not free the reserved memory for the page map, this patch do it.
>
> Hello Wei,
> Just curious if this patch breaks MEMORY_HOTPLUG?
>
> >
> > Signed-off-by: Wei Li <liwei213@huawei.com>
> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> > ---
> > arch/arm64/mm/init.c | 81
> > +++++++++++++++++++++++++++++++++++++++++++++-------
> > 1 file changed, 71 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index
> > 1e93cfc7c47a..d1b56b47d5ba 100644
> > --- a/arch/arm64/mm/init.c
> > +++ b/arch/arm64/mm/init.c
> > @@ -441,7 +441,48 @@ void __init bootmem_init(void)
> > memblock_dump_all();
> > }
> >
>
> Thanks
> Barry
next prev parent reply other threads:[~2020-07-09 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200708015555.14946-1-liwei213@huawei.com>
2020-07-08 7:18 ` [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP Song Bao Hua (Barry Song)
2020-07-08 7:51 ` 答复: " liwei (CM)
2020-07-09 12:27 ` Song Bao Hua (Barry Song) [this message]
2020-07-21 1:56 ` liwei (CM)
2020-07-21 6:35 ` Mike Rapoport
2020-07-21 12:27 ` 答复: " liwei (CM)
2020-07-21 7:32 Wei Li
2020-07-22 6:07 ` Mike Rapoport
2020-07-23 2:33 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B926444035E5E2439431908E3842AFD256289A@DGGEMI525-MBS.china.huawei.com \
--to=song.bao.hua@hisilicon.com \
--cc=catalin.marinas@arm.com \
--cc=fengbaopeng2@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=nsaenzjulienne@suse.de \
--cc=rppt@linux.ibm.com \
--cc=saberlily.xia@hisilicon.com \
--cc=steve.capper@arm.com \
--cc=sujunfei2@hisilicon.com \
--cc=will@kernel.org \
--cc=yaobaofeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).