* [PATCH] tcm_fc: rcu_deref outside rcu lock/unlock section
@ 2012-08-18 12:10 Denis Efremov
2012-08-18 22:35 ` Nicholas A. Bellinger
0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2012-08-18 12:10 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: Denis Efremov, Paul E. McKenney, Jesper Juhl, target-devel,
linux-kernel, ldv-project
Use rcu_dereference_protected in order to prevent lockdep
complaint. Sequel of the patch 863555be
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
drivers/target/tcm_fc/tfc_sess.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
index 87901fa..3c9e5b5 100644
--- a/drivers/target/tcm_fc/tfc_sess.c
+++ b/drivers/target/tcm_fc/tfc_sess.c
@@ -456,7 +456,9 @@ static void ft_prlo(struct fc_rport_priv *rdata)
struct ft_tport *tport;
mutex_lock(&ft_lport_lock);
- tport = rcu_dereference(rdata->local_port->prov[FC_TYPE_FCP]);
+ tport = rcu_dereference_protected(rdata->local_port->prov[FC_TYPE_FCP],
+ lockdep_is_held(&ft_lport_lock));
+
if (!tport) {
mutex_unlock(&ft_lport_lock);
return;
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcm_fc: rcu_deref outside rcu lock/unlock section
2012-08-18 12:10 [PATCH] tcm_fc: rcu_deref outside rcu lock/unlock section Denis Efremov
@ 2012-08-18 22:35 ` Nicholas A. Bellinger
2012-08-20 16:39 ` Rustad, Mark D
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas A. Bellinger @ 2012-08-18 22:35 UTC (permalink / raw)
To: Denis Efremov
Cc: Paul E. McKenney, Jesper Juhl, target-devel, linux-kernel,
ldv-project, Rustad, Mark D, Patil, Kiran
On Sat, 2012-08-18 at 16:10 +0400, Denis Efremov wrote:
> Use rcu_dereference_protected in order to prevent lockdep
> complaint. Sequel of the patch 863555be
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
> ---
> drivers/target/tcm_fc/tfc_sess.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
> index 87901fa..3c9e5b5 100644
> --- a/drivers/target/tcm_fc/tfc_sess.c
> +++ b/drivers/target/tcm_fc/tfc_sess.c
> @@ -456,7 +456,9 @@ static void ft_prlo(struct fc_rport_priv *rdata)
> struct ft_tport *tport;
>
> mutex_lock(&ft_lport_lock);
> - tport = rcu_dereference(rdata->local_port->prov[FC_TYPE_FCP]);
> + tport = rcu_dereference_protected(rdata->local_port->prov[FC_TYPE_FCP],
> + lockdep_is_held(&ft_lport_lock));
> +
> if (!tport) {
> mutex_unlock(&ft_lport_lock);
> return;
This looks OK to silence lockdep. CC'ing MDR + Kiran for good measure
here, and will move from target-pending queue -> master with their ACK.
Thanks Dennis!
--nab
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcm_fc: rcu_deref outside rcu lock/unlock section
2012-08-18 22:35 ` Nicholas A. Bellinger
@ 2012-08-20 16:39 ` Rustad, Mark D
0 siblings, 0 replies; 3+ messages in thread
From: Rustad, Mark D @ 2012-08-20 16:39 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: Denis Efremov, Paul E. McKenney, Jesper Juhl,
<target-devel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<ldv-project@ispras.ru>,
Patil, Kiran
On Aug 18, 2012, at 3:35 PM, Nicholas A. Bellinger wrote:
> On Sat, 2012-08-18 at 16:10 +0400, Denis Efremov wrote:
>> Use rcu_dereference_protected in order to prevent lockdep
>> complaint. Sequel of the patch 863555be
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
>> ---
>> drivers/target/tcm_fc/tfc_sess.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
>> index 87901fa..3c9e5b5 100644
>> --- a/drivers/target/tcm_fc/tfc_sess.c
>> +++ b/drivers/target/tcm_fc/tfc_sess.c
>> @@ -456,7 +456,9 @@ static void ft_prlo(struct fc_rport_priv *rdata)
>> struct ft_tport *tport;
>>
>> mutex_lock(&ft_lport_lock);
>> - tport = rcu_dereference(rdata->local_port->prov[FC_TYPE_FCP]);
>> + tport = rcu_dereference_protected(rdata->local_port->prov[FC_TYPE_FCP],
>> + lockdep_is_held(&ft_lport_lock));
>> +
>> if (!tport) {
>> mutex_unlock(&ft_lport_lock);
>> return;
>
> This looks OK to silence lockdep. CC'ing MDR + Kiran for good measure
> here, and will move from target-pending queue -> master with their ACK.
>
> Thanks Dennis!
>
> --nab
Ack. In fact I wonder why I didn't encounter it myself.
--
Mark Rustad, LAN Access Division, Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-20 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-18 12:10 [PATCH] tcm_fc: rcu_deref outside rcu lock/unlock section Denis Efremov
2012-08-18 22:35 ` Nicholas A. Bellinger
2012-08-20 16:39 ` Rustad, Mark D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).