linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] efi: Fix argument types for SetVariable()
Date: Thu, 9 Jun 2011 12:02:53 -0700	[thread overview]
Message-ID: <BANLkTi=wmubWjiQ3Lw7s_iA11AoE+J3BPQ@mail.gmail.com> (raw)
In-Reply-To: <1307388985-7852-1-git-send-email-mjg@redhat.com>

On Mon, Jun 6, 2011 at 12:36 PM, Matthew Garrett <mjg@redhat.com> wrote:
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index e376270..0758753 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -168,7 +168,7 @@ typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t *vendor,
>  typedef efi_status_t efi_get_next_variable_t (unsigned long *name_size, efi_char16_t *name,
>                                              efi_guid_t *vendor);
>  typedef efi_status_t efi_set_variable_t (efi_char16_t *name, efi_guid_t *vendor,
> -                                        unsigned long attr, unsigned long data_size,
> +                                        u32 attr, unsigned long data_size,
>                                         void *data);
>  typedef efi_status_t efi_get_next_high_mono_count_t (u32 *count);
>  typedef void efi_reset_system_t (int reset_type, efi_status_t status,

x86 isn't the only user of <linux/efi.h>

Building next-20110609 I see:

arch/ia64/kernel/efi.c:578: warning: assignment from incompatible pointer type
arch/ia64/kernel/efi.c:701: warning: assignment from incompatible pointer type

-Tony

  parent reply	other threads:[~2011-06-09 19:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 19:36 [PATCH 1/2] efi: Fix argument types for SetVariable() Matthew Garrett
2011-06-06 19:36 ` [PATCH 2/2] efi: Add infrastructure for UEFI 2.0 runtime services Matthew Garrett
2011-06-06 21:22   ` [tip:x86/efi] x86, " tip-bot for Matthew Garrett
2011-06-20 22:42   ` [PATCH 2/2] " Mike Waychison
2011-06-20 22:44     ` Mike Waychison
2011-06-21 15:02     ` Matthew Garrett
2011-06-06 21:21 ` [tip:x86/efi] x86, efi: Fix argument types for SetVariable() tip-bot for Matthew Garrett
2011-06-09 19:02 ` Tony Luck [this message]
2011-06-09 19:09   ` [PATCH 1/2] " Matthew Garrett
2011-07-06 20:48 ` [PATCH v2] " Matthew Garrett
2011-07-06 21:36   ` Luck, Tony
2011-07-07  9:33   ` Ingo Molnar
2011-07-07 11:38     ` Matthew Garrett
2011-07-07 11:40       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=wmubWjiQ3Lw7s_iA11AoE+J3BPQ@mail.gmail.com' \
    --to=tony.luck@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).