From: Hillf Danton <dhillf@gmail.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: remove resetting exec_start in put_prev_task_rt()
Date: Sat, 4 Jun 2011 12:26:18 +0800 [thread overview]
Message-ID: <BANLkTikx9gENppLG4xwYOKSoFyhY+xXS=Q@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikoO5F5H4sEUoDPKX3qiahuehp=Mg@mail.gmail.com>
On Thu, Jun 2, 2011 at 4:04 PM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> On Wed, Jun 1, 2011 at 10:03 PM, Hillf Danton <dhillf@gmail.com> wrote:
>> Resetting exec_start, after updated in update_curr_rt(), could open window for
>> messing up the subsequent computations of delta_exec of the given task.
>
> I can't see how could this happen. what kind of 'subsequent computations'
> do you mean?
>
> But because exec_start will be reset by _pick_next_task_rt()/set_curr_task_rt(),
> you patch is ok. IMHO it is not critical, it's just cleanup instead.
>
H i Yong
The window is closed in the two cases, as you tip fingered, would you please
say a few more words about the window and tick timer?
thanks
Hillf
next prev parent reply other threads:[~2011-06-04 4:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 14:03 [PATCH] sched: remove resetting exec_start in put_prev_task_rt() Hillf Danton
2011-06-01 14:22 ` Steven Rostedt
2011-06-02 8:04 ` Yong Zhang
2011-06-04 4:26 ` Hillf Danton [this message]
2011-06-09 12:34 ` Steven Rostedt
2011-06-10 2:38 ` Yong Zhang
2011-06-10 2:41 ` Steven Rostedt
2011-06-10 10:19 ` Peter Zijlstra
2011-06-10 14:48 ` Hillf Danton
2011-06-10 14:58 ` Steven Rostedt
2011-06-10 15:12 ` Hillf Danton
2011-08-14 16:03 ` [tip:sched/core] sched: Remove " tip-bot for Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikx9gENppLG4xwYOKSoFyhY+xXS=Q@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).