linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benson Leung <bleung@chromium.org>
To: lars@metafoo.de, cbouatmailru@gmail.com
Cc: rklein@nvidia.com, linux-kernel@vger.kernel.org,
	Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH v2] gpio-charger: Add gpio_charger_resume
Date: Wed, 6 Apr 2011 02:08:58 -0700	[thread overview]
Message-ID: <BANLkTinh-Chz7GzdHLqpSSzq4BzzwX5axw@mail.gmail.com> (raw)
In-Reply-To: <1301796792-28806-1-git-send-email-bleung@chromium.org>

Hi Lars,

Please take another look.

Thanks,
Benson

On Sat, Apr 2, 2011 at 7:13 PM, Benson Leung <bleung@chromium.org> wrote:
> Gpio charger should notify if the gpio state had changed
> during suspend. This will send a CHANGED event each time
> the system resumes, ensuring a plug/unplug of the charger
> is not missed.
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
>
> --
> Version history :
> v2 : Changed to use dev_pm_ops
> v1 : Initial
> ---
>  drivers/power/gpio-charger.c |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c
> index 25b88ac..df29059 100644
> --- a/drivers/power/gpio-charger.c
> +++ b/drivers/power/gpio-charger.c
> @@ -161,12 +161,32 @@ static int __devexit gpio_charger_remove(struct platform_device *pdev)
>        return 0;
>  }
>
> +#if defined(CONFIG_PM)
> +static int gpio_charger_resume(struct device *dev)
> +{
> +       struct platform_device *pdev = to_platform_device(dev);
> +       struct gpio_charger *gpio_charger = platform_get_drvdata(pdev);
> +
> +       power_supply_changed(&gpio_charger->charger);
> +
> +       return 0;
> +}
> +
> +static const struct dev_pm_ops gpio_charger_pm_ops = {
> +       .resume         = gpio_charger_resume,
> +};
> +#endif
> +
> +
>  static struct platform_driver gpio_charger_driver = {
>        .probe = gpio_charger_probe,
>        .remove = __devexit_p(gpio_charger_remove),
>        .driver = {
>                .name = "gpio-charger",
>                .owner = THIS_MODULE,
> +#if defined(CONFIG_PM)
> +               .pm = &gpio_charger_pm_ops,
> +#endif
>        },
>  };
>
> --
> 1.7.1
>
>



-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org

  reply	other threads:[~2011-04-06  9:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-03  2:13 [PATCH v2] gpio-charger: Add gpio_charger_resume Benson Leung
2011-04-06  9:08 ` Benson Leung [this message]
2011-04-06 14:40   ` Lars-Peter Clausen
2011-04-06 20:58     ` Benson Leung
2011-04-06 23:55 ` [PATCH v3] " Benson Leung
2011-04-07  0:15   ` Lars-Peter Clausen
2011-04-12  4:19     ` Benson Leung
2011-04-20 17:25       ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinh-Chz7GzdHLqpSSzq4BzzwX5axw@mail.gmail.com \
    --to=bleung@chromium.org \
    --cc=cbouatmailru@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rklein@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).