From: Tong Zhang <ztong0001@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
"open list:DRM DRIVER FOR QXL VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>,
"open list:DRM DRIVER FOR QXL VIRTUAL GPU"
<spice-devel@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/qxl: do not run release if qxl failed to init
Date: Fri, 5 Feb 2021 10:31:58 -0500 [thread overview]
Message-ID: <BCB24CD0-FD0F-4202-AD93-02A7EDC229C9@gmail.com> (raw)
In-Reply-To: <20210205074330.zsb2lg5umgkxh2p3@sirius.home.kraxel.org>
On Feb 5, 2021, at 2:43 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Thu, Feb 04, 2021 at 11:30:50AM -0500, Tong Zhang wrote:
>> if qxl_device_init() fail, drm device will not be registered,
>> in this case, do not run qxl_drm_release()
>
> How do you trigger this?
>
This can be triggered by changing the QXL VGA rom magic value.
In the QEMU source code ./hw/display/qxl.c
or change the QXL_ROM_MAGIC in spice header file
- Tong
> take care,
> Gerd
>
prev parent reply other threads:[~2021-02-05 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 16:30 [PATCH v2] drm/qxl: do not run release if qxl failed to init Tong Zhang
2021-02-05 7:43 ` Gerd Hoffmann
2021-02-05 15:31 ` Tong Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BCB24CD0-FD0F-4202-AD93-02A7EDC229C9@gmail.com \
--to=ztong0001@gmail.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).