Alps touchpad generates IRQ storm after S3

Alps touchpad generates IRQ storm after S3

[Kai-Heng Feng]

Hi Masaki,

The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm after  
system suspend (S3).
Commit "HID: i2c-hid: Don't reset device upon system resume” which solves  
the same issue for other vendors, cause the issue on Alps touchpad.
So I’d like to know the correct command Alps touchpad expects after system  
resume.

Also Cc Mario because this could relate to BIOS.

Kai-Heng

RE: Alps touchpad generates IRQ storm after S3

[Masaki Ota]

Hi, Kai-Heng,

Sorry, I'm not in charge of Linux task now.

Hi, XiaoJian,

Please check the following mail.
If you have any question, please ask Kai-Heng.

Best Regards,
Masaki Ota
-----Original Message-----
From: Kai-Heng Feng <kai.heng.feng@canonical.com> 
Sent: Wednesday, August 28, 2019 3:22 PM
To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Alps touchpad generates IRQ storm after S3

Hi Masaki,

The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm after system suspend (S3).
Commit "HID: i2c-hid: Don't reset device upon system resume” which solves the same issue for other vendors, cause the issue on Alps touchpad.
So I’d like to know the correct command Alps touchpad expects after system resume.

Also Cc Mario because this could relate to BIOS.

Kai-Heng

RE: Alps touchpad generates IRQ storm after S3

[Xiaojian Cao]

Hi Ota-san,

OK, we will look into it.


Hi Kai-Heng,

We will try to reproduce this issue first, could you please tell me the target Ubuntu version?

Best regards, 
Jason

-----Original Message-----
From: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com> 
Sent: Wednesday, August 28, 2019 2:35 PM
To: 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; 斉藤 直樹 Naoki Saito <naoki.saito@alpsalpine.com>
Subject: RE: Alps touchpad generates IRQ storm after S3

Hi, Kai-Heng,

Sorry, I'm not in charge of Linux task now.

Hi, XiaoJian,

Please check the following mail.
If you have any question, please ask Kai-Heng.

Best Regards,
Masaki Ota
-----Original Message-----
From: Kai-Heng Feng <kai.heng.feng@canonical.com> 
Sent: Wednesday, August 28, 2019 3:22 PM
To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Alps touchpad generates IRQ storm after S3

Hi Masaki,

The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm after system suspend (S3).
Commit "HID: i2c-hid: Don't reset device upon system resume” which solves the same issue for other vendors, cause the issue on Alps touchpad.
So I’d like to know the correct command Alps touchpad expects after system resume.

Also Cc Mario because this could relate to BIOS.

Kai-Heng

Re: Alps touchpad generates IRQ storm after S3

[Kai-Heng Feng]

Hi Xiaojian,

at 14:51, Xiaojian Cao <xiaojian.cao@cn.alps.com> wrote:

> Hi Ota-san,
>
> OK, we will look into it.
>
>
> Hi Kai-Heng,
>
> We will try to reproduce this issue first, could you please tell me the  
> target Ubuntu version?

It’s distro-agnostic, any distro with mainline Linux can reproduce the issue.

Kai-Heng

>
> Best regards,
> Jason
>
> -----Original Message-----
> From: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
> Sent: Wednesday, August 28, 2019 2:35 PM
> To: 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; Kai-Heng Feng  
> <kai.heng.feng@canonical.com>
> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE  
> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List  
> <linux-kernel@vger.kernel.org>; 斉藤 直樹 Naoki Saito  
> <naoki.saito@alpsalpine.com>
> Subject: RE: Alps touchpad generates IRQ storm after S3
>
> Hi, Kai-Heng,
>
> Sorry, I'm not in charge of Linux task now.
>
> Hi, XiaoJian,
>
> Please check the following mail.
> If you have any question, please ask Kai-Heng.
>
> Best Regards,
> Masaki Ota
> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Wednesday, August 28, 2019 3:22 PM
> To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE  
> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List  
> <linux-kernel@vger.kernel.org>
> Subject: Alps touchpad generates IRQ storm after S3
>
> Hi Masaki,
>
> The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm  
> after system suspend (S3).
> Commit "HID: i2c-hid: Don't reset device upon system resume” which solves  
> the same issue for other vendors, cause the issue on Alps touchpad.
> So I’d like to know the correct command Alps touchpad expects after  
> system resume.
>
> Also Cc Mario because this could relate to BIOS.
>
> Kai-Heng

RE: Alps touchpad generates IRQ storm after S3

[Mario.Limonciello]

KH,

Just make sure I understand details.

> Commit "HID: i2c-hid: Don't reset device upon system resume

If you revert this it's fixed on this system?

In that commit you had mentioned if this causes problems it might be worth
quirking just Raydium but commit afbb1169ed5b58cfca017e368b53e019cf285853
confirmed that it helped several other systems too.

If the conclusion from this investigation this is only fixable via touchpad FW update
it might be worth quirking this touchpad/touchpad FW/system combination.

> Also Cc Mario because this could relate to BIOS.

Also I assume this is on current stable BIOS/EC release, right?

Thanks,

> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Wednesday, August 28, 2019 1:58 AM
> To: Xiaojian Cao
> Cc: Masaki Ota; Limonciello, Mario; open list:HID CORE LAYER; Linux Kernel
> Mailing List; Naoki Saito
> Subject: Re: Alps touchpad generates IRQ storm after S3
> 
> 
> [EXTERNAL EMAIL]
> 
> Hi Xiaojian,
> 
> at 14:51, Xiaojian Cao <xiaojian.cao@cn.alps.com> wrote:
> 
> > Hi Ota-san,
> >
> > OK, we will look into it.
> >
> >
> > Hi Kai-Heng,
> >
> > We will try to reproduce this issue first, could you please tell me the
> > target Ubuntu version?
> 
> It’s distro-agnostic, any distro with mainline Linux can reproduce the issue.
> 
> Kai-Heng
> 
> >
> > Best regards,
> > Jason
> >
> > -----Original Message-----
> > From: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
> > Sent: Wednesday, August 28, 2019 2:35 PM
> > To: 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; Kai-Heng Feng
> > <kai.heng.feng@canonical.com>
> > Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
> > LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>; 斉藤 直樹 Naoki Saito
> > <naoki.saito@alpsalpine.com>
> > Subject: RE: Alps touchpad generates IRQ storm after S3
> >
> > Hi, Kai-Heng,
> >
> > Sorry, I'm not in charge of Linux task now.
> >
> > Hi, XiaoJian,
> >
> > Please check the following mail.
> > If you have any question, please ask Kai-Heng.
> >
> > Best Regards,
> > Masaki Ota
> > -----Original Message-----
> > From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > Sent: Wednesday, August 28, 2019 3:22 PM
> > To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
> > Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
> > LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>
> > Subject: Alps touchpad generates IRQ storm after S3
> >
> > Hi Masaki,
> >
> > The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm
> > after system suspend (S3).
> > Commit "HID: i2c-hid: Don't reset device upon system resume” which solves
> > the same issue for other vendors, cause the issue on Alps touchpad.
> > So I’d like to know the correct command Alps touchpad expects after
> > system resume.
> >
> > Also Cc Mario because this could relate to BIOS.
> >
> > Kai-Heng
> 

Re: Alps touchpad generates IRQ storm after S3

[Kai-Heng Feng]

Hi Mario,

at 21:25, <Mario.Limonciello@dell.com> <Mario.Limonciello@dell.com> wrote:

> KH,
>
> Just make sure I understand details.
>
>> Commit "HID: i2c-hid: Don't reset device upon system resume
>
> If you revert this it's fixed on this system?

Yes. Once reset is used instead of  the issue is gone.

>
> In that commit you had mentioned if this causes problems it might be worth
> quirking just Raydium but commit afbb1169ed5b58cfca017e368b53e019cf285853
> confirmed that it helped several other systems too.
>
> If the conclusion from this investigation this is only fixable via  
> touchpad FW update
> it might be worth quirking this touchpad/touchpad FW/system combination.

Hopefully there’s a better solution from ALPS :)

>
>> Also Cc Mario because this could relate to BIOS.
>
> Also I assume this is on current stable BIOS/EC release, right?

Yes. The BIOS version is 1.10.1.

The IRQ storm stops as soon as the touchpad gets touched.

Kai-Heng

>
> Thanks,
>
>> -----Original Message-----
>> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> Sent: Wednesday, August 28, 2019 1:58 AM
>> To: Xiaojian Cao
>> Cc: Masaki Ota; Limonciello, Mario; open list:HID CORE LAYER; Linux Kernel
>> Mailing List; Naoki Saito
>> Subject: Re: Alps touchpad generates IRQ storm after S3
>>
>>
>> [EXTERNAL EMAIL]
>>
>> Hi Xiaojian,
>>
>> at 14:51, Xiaojian Cao <xiaojian.cao@cn.alps.com> wrote:
>>
>>> Hi Ota-san,
>>>
>>> OK, we will look into it.
>>>
>>>
>>> Hi Kai-Heng,
>>>
>>> We will try to reproduce this issue first, could you please tell me the
>>> target Ubuntu version?
>>
>> It’s distro-agnostic, any distro with mainline Linux can reproduce the  
>> issue.
>>
>> Kai-Heng
>>
>>> Best regards,
>>> Jason
>>>
>>> -----Original Message-----
>>> From: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
>>> Sent: Wednesday, August 28, 2019 2:35 PM
>>> To: 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; Kai-Heng Feng
>>> <kai.heng.feng@canonical.com>
>>> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
>>> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
>>> <linux-kernel@vger.kernel.org>; 斉藤 直樹 Naoki Saito
>>> <naoki.saito@alpsalpine.com>
>>> Subject: RE: Alps touchpad generates IRQ storm after S3
>>>
>>> Hi, Kai-Heng,
>>>
>>> Sorry, I'm not in charge of Linux task now.
>>>
>>> Hi, XiaoJian,
>>>
>>> Please check the following mail.
>>> If you have any question, please ask Kai-Heng.
>>>
>>> Best Regards,
>>> Masaki Ota
>>> -----Original Message-----
>>> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>> Sent: Wednesday, August 28, 2019 3:22 PM
>>> To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
>>> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
>>> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
>>> <linux-kernel@vger.kernel.org>
>>> Subject: Alps touchpad generates IRQ storm after S3
>>>
>>> Hi Masaki,
>>>
>>> The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm
>>> after system suspend (S3).
>>> Commit "HID: i2c-hid: Don't reset device upon system resume” which solves
>>> the same issue for other vendors, cause the issue on Alps touchpad.
>>> So I’d like to know the correct command Alps touchpad expects after
>>> system resume.
>>>
>>> Also Cc Mario because this could relate to BIOS.
>>>
>>> Kai-Heng

Re: Alps touchpad generates IRQ storm after S3

[Kai-Heng Feng]

Hi Xiaojian,

> On Aug 28, 2019, at 22:43, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> 
> Hi Mario,
> 
> at 21:25, <Mario.Limonciello@dell.com> <Mario.Limonciello@dell.com> wrote:
> 
>> KH,
>> 
>> Just make sure I understand details.
>> 
>>> Commit "HID: i2c-hid: Don't reset device upon system resume
>> 
>> If you revert this it's fixed on this system?
> 
> Yes. Once reset is used instead of  the issue is gone.

Do you figure out the correct command to use here?

Kai-Heng

> 
>> 
>> In that commit you had mentioned if this causes problems it might be worth
>> quirking just Raydium but commit afbb1169ed5b58cfca017e368b53e019cf285853
>> confirmed that it helped several other systems too.
>> 
>> If the conclusion from this investigation this is only fixable via touchpad FW update
>> it might be worth quirking this touchpad/touchpad FW/system combination.
> 
> Hopefully there’s a better solution from ALPS :)
> 
>> 
>>> Also Cc Mario because this could relate to BIOS.
>> 
>> Also I assume this is on current stable BIOS/EC release, right?
> 
> Yes. The BIOS version is 1.10.1.
> 
> The IRQ storm stops as soon as the touchpad gets touched.
> 
> Kai-Heng
> 
>> 
>> Thanks,
>> 
>>> -----Original Message-----
>>> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>> Sent: Wednesday, August 28, 2019 1:58 AM
>>> To: Xiaojian Cao
>>> Cc: Masaki Ota; Limonciello, Mario; open list:HID CORE LAYER; Linux Kernel
>>> Mailing List; Naoki Saito
>>> Subject: Re: Alps touchpad generates IRQ storm after S3
>>> 
>>> 
>>> [EXTERNAL EMAIL]
>>> 
>>> Hi Xiaojian,
>>> 
>>> at 14:51, Xiaojian Cao <xiaojian.cao@cn.alps.com> wrote:
>>> 
>>>> Hi Ota-san,
>>>> 
>>>> OK, we will look into it.
>>>> 
>>>> 
>>>> Hi Kai-Heng,
>>>> 
>>>> We will try to reproduce this issue first, could you please tell me the
>>>> target Ubuntu version?
>>> 
>>> It’s distro-agnostic, any distro with mainline Linux can reproduce the issue.
>>> 
>>> Kai-Heng
>>> 
>>>> Best regards,
>>>> Jason
>>>> 
>>>> -----Original Message-----
>>>> From: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
>>>> Sent: Wednesday, August 28, 2019 2:35 PM
>>>> To: 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; Kai-Heng Feng
>>>> <kai.heng.feng@canonical.com>
>>>> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
>>>> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
>>>> <linux-kernel@vger.kernel.org>; 斉藤 直樹 Naoki Saito
>>>> <naoki.saito@alpsalpine.com>
>>>> Subject: RE: Alps touchpad generates IRQ storm after S3
>>>> 
>>>> Hi, Kai-Heng,
>>>> 
>>>> Sorry, I'm not in charge of Linux task now.
>>>> 
>>>> Hi, XiaoJian,
>>>> 
>>>> Please check the following mail.
>>>> If you have any question, please ask Kai-Heng.
>>>> 
>>>> Best Regards,
>>>> Masaki Ota
>>>> -----Original Message-----
>>>> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>>> Sent: Wednesday, August 28, 2019 3:22 PM
>>>> To: 太田 真喜 Masaki Ota <masaki.ota@alpsalpine.com>
>>>> Cc: Mario Limonciello <mario.limonciello@dell.com>; open list:HID CORE
>>>> LAYER <linux-input@vger.kernel.org>; Linux Kernel Mailing List
>>>> <linux-kernel@vger.kernel.org>
>>>> Subject: Alps touchpad generates IRQ storm after S3
>>>> 
>>>> Hi Masaki,
>>>> 
>>>> The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm
>>>> after system suspend (S3).
>>>> Commit "HID: i2c-hid: Don't reset device upon system resume” which solves
>>>> the same issue for other vendors, cause the issue on Alps touchpad.
>>>> So I’d like to know the correct command Alps touchpad expects after
>>>> system resume.
>>>> 
>>>> Also Cc Mario because this could relate to BIOS.
>>>> 
>>>> Kai-Heng
> 
>