From: "Pawnikar, Sumeet R" <sumeet.r.pawnikar@intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Zhang, Rui" <rui.zhang@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Subject: RE: [PATCH v2] powercap: Add Power Limit4 support
Date: Thu, 16 Jul 2020 05:10:54 +0000 [thread overview]
Message-ID: <BL0PR11MB3363757AEC2CF48D77F68F89BB7F0@BL0PR11MB3363.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ec0336b09ccf932aef6bbe51fed1e79c864c55ea.camel@linux.intel.com>
> -----Original Message-----
> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Sent: Wednesday, July 15, 2020 5:44 AM
> To: Rafael J. Wysocki <rafael@kernel.org>; Pawnikar, Sumeet R
> <sumeet.r.pawnikar@intel.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>; Zhang, Rui
> <rui.zhang@intel.com>; Linux PM <linux-pm@vger.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Shevchenko, Andriy
> <andriy.shevchenko@intel.com>
> Subject: Re: [PATCH v2] powercap: Add Power Limit4 support
>
> On Tue, 2020-07-14 at 15:21 +0200, Rafael J. Wysocki wrote:
> > >
>
> [...]
>
> > On Tue, Jul 14, 2020 at 10:22 AM Sumeet Pawnikar
> > <sumeet.r.pawnikar@intel.com> wrote:
> >
> > Srinivas, does the patch look good to you?
>
> Some minor comments then Summet can add my
>
> Reviewed-and-tested-by: Srinivas Pandruvada <
> srinivas.pandruvada@linux.intel.com>
>
Thanks Srinivas for testing this.
I will address your below comment
and submit v3 with above tag.
> > > ---
> > > Changes in v2:
> > > - Addressed review comments from Rafael.
> > > - Made the commit message more clearer.
> > > - Updated powercap documentation.
> > > ---
> > >
>
> [...]
>
> > > 0,1).
> > > +Depending on different power zones, the Intel RAPL technology
> > > allows
> > > +one or multiple constraints like short term, long term and peak
> > > power,
> > > +with different time windows to be applied to each power zone.
> I think better to spell out that time window is not applicable to "peak power".
> Otherwise someone will send a bug report.
>
>
> [...]
>
> > > static int rapl_msr_probe(struct platform_device *pdev) {
> > > int ret;
> > > + const struct x86_cpu_id *id =
> > > x86_match_cpu(pl4_support_ids);
>
> To match coding style in this file:
> const struct x86_cpu_id *id = x86_match_cpu(pl4_support_ids);
> int ret;
>
Thanks for review.
Regards,
Sumeet.
> > > rapl_msr_priv.read_raw = rapl_msr_read_raw;
>
> Thanks,
> Srinivas
next prev parent reply other threads:[~2020-07-16 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 8:28 [PATCH v2] powercap: Add Power Limit4 support Sumeet Pawnikar
2020-07-14 13:21 ` Rafael J. Wysocki
2020-07-15 0:13 ` Srinivas Pandruvada
2020-07-16 5:10 ` Pawnikar, Sumeet R [this message]
2020-07-16 5:06 ` Pawnikar, Sumeet R
2020-07-28 20:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3363757AEC2CF48D77F68F89BB7F0@BL0PR11MB3363.namprd11.prod.outlook.com \
--to=sumeet.r.pawnikar@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).