linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen Gang <xili_gchen_5257@hotmail.com>
To: Dave Jones <davej@codemonkey.org.uk>,
	Michael Cree <mcree@orcon.net.nz>,
	rth@twiddle.net, ink@jurassic.park.msu.ru,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-alpha@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha: Wire up missing syscalls
Date: Wed, 13 May 2015 08:55:54 +0800	[thread overview]
Message-ID: <BLU437-SMTP63A0F14D55020B3B3489E4B9D90@phx.gbl> (raw)
In-Reply-To: <20150512142942.GA12264@codemonkey.org.uk>

On 05/12/2015 10:29 PM, Dave Jones wrote:
> On Tue, May 12, 2015 at 08:59:52PM +1200, Michael Cree wrote:
>  > On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
>  > > The related warnings:
>  > > 
>  > >     CALL    scripts/checksyscalls.sh
>  > >   <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
>  > >   <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
>  > >   <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
>  > >   <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
>  > >   <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
>  > 
>  > Chen: Have you tested the syscalls you have wired up?
>  > 
>  > I have a suspicion that more is required to wire up the seccomp
>  > syscall.
> 
> likewise sys_bpf judging by the absence of bpf_int_jit_compile and friends in arch/alpha
> The weak symbols mean it probably compiles/links, but it doesn't actually do
> anything, and now instead of -ENOSYS, anyone trying to actually use that syscall
> on alpha will get weird results.
> 
> Shutting up warnings like this strikes me as the wrong thing to do.
> 

It sounds reasonable. For me, we need to wire up implemented syscalls,
and still left the unimplemented syscalls as building warnings.

If no any additional reply, I shall try to send patch v2 for it within
this week (2015-05-17).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

  reply	other threads:[~2015-05-13  0:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09 18:33 [PATCH] alpha: Wire up missing syscalls Chen Gang
2015-05-12  8:59 ` Michael Cree
2015-05-12 11:40   ` Chen Gang
2015-05-12 11:46     ` Chen Gang
2015-05-12 14:29   ` Dave Jones
2015-05-13  0:55     ` Chen Gang [this message]
2015-05-18  4:44       ` Chen Gang
2015-05-12 17:36   ` Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU437-SMTP63A0F14D55020B3B3489E4B9D90@phx.gbl \
    --to=xili_gchen_5257@hotmail.com \
    --cc=davej@codemonkey.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).